This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Dart to 050561fd82be5e775316223c9d2d9e7e5e596c8e #6271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crelier
approved these changes
Sep 17, 2018
Contributor
crelier
left a comment
crelier
left a comment
There was a problem hiding this comment.
LGTM, as long as the tests pass.
aam
approved these changes
Sep 17, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 17, 2018
flutter/engine@b0b19d6...dcbc8a8 git log b0b19d6..dcbc8a8 --no-merges --oneline dcbc8a8 Roll Dart to 050561fd82be5e775316223c9d2d9e7e5e596c8e (flutter/engine#6271) ba77529 Ensure that Layer::AutoSaveLayer objects are not immediately destructed (flutter/engine#6264) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Sep 17, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 17, 2018
flutter/engine@b0b19d6...dbfa827 git log b0b19d6..dbfa827 --no-merges --oneline dbfa827 [fuchsia] Fixes for the Fuchsia build (flutter/engine#6273) dcbc8a8 Roll Dart to 050561fd82be5e775316223c9d2d9e7e5e596c8e (flutter/engine#6271) ba77529 Ensure that Layer::AutoSaveLayer objects are not immediately destructed (flutter/engine#6264) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 18, 2018
flutter/engine@b0b19d6...cdbe214 git log b0b19d6..cdbe214 --no-merges --oneline cdbe214 Update test .gitignore (flutter/engine#6272) dbfa827 [fuchsia] Fixes for the Fuchsia build (flutter/engine#6273) dcbc8a8 Roll Dart to 050561fd82be5e775316223c9d2d9e7e5e596c8e (flutter/engine#6271) ba77529 Ensure that Layer::AutoSaveLayer objects are not immediately destructed (flutter/engine#6264) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
dart-lang/sdk@050561f [vm] Relax recently added assertion in Dart 1 mode dart-lang/sdk@6c712f1 Add a fix to create a mixin dart-lang/sdk@cc08d0e Add operators `&`, `|` and `^` to `bool`. dart-lang/sdk@5af9844 Language specification reorganization. dart-lang/sdk@2cb2ac4 Optimize `ClassHierarchyBuilder.isInheritedInSubtypeOf`. dart-lang/sdk@e8880fd Fix handling of unary- in the analyzer/FE comparison tool. dart-lang/sdk@bd103eb Store unlinked data with unlinked salt. dart-lang/sdk@c5d77d1 Support mixins in more places in index and search. dart-lang/sdk@c3bdb6c Refactor summary resynthesis tests in preparation for using the one-phase summary API. dart-lang/sdk@ddcb8b7 Remove unused SubtypeManager. dart-lang/sdk@76091c1 [vm/bytecode] Add PushNull, PushTrue, PushFalse and PushInt bytecodes dart-lang/sdk@a80b13e Add an assist to convert from a class to a mixin dart-lang/sdk@0f45b2e Fix spelling hexidecimal -> hexadecimal dart-lang/sdk@348ed30 [vm/kernel] In async transformation check if strongMode is on. dart-lang/sdk@c6c4748 [vm/bytecode] Bytecode compilation dart-lang/sdk@78d9a28 [vm, arm] Globally block LR for register allocation. dart-lang/sdk@078be2c [vm] Add library private key to the Class hash function for reload. dart-lang/sdk@4fab565 Several minor fixes to the analyzer/FE comparison tool. dart-lang/sdk@eb96871 Compute unlinked API signatures without unlinked summaries. dart-lang/sdk@98d25ed fix flutter#34450, implement boolean bitwise operators in dartdevc dart-lang/sdk@229d793 [vm/compiler] Support materializing unboxed variables when entering catch. dart-lang/sdk@eec96f9 [vm/kernel] Preserve strong mode types in async transformation dart-lang/sdk@bf4facd Handle errors when comparing analyzer and front end behaviors. dart-lang/sdk@3e9f4e6 dart2js: generate simple '==' in more cases
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
dart-lang/sdk@050561f [vm] Relax recently added assertion in Dart 1 mode dart-lang/sdk@6c712f1 Add a fix to create a mixin dart-lang/sdk@cc08d0e Add operators `&`, `|` and `^` to `bool`. dart-lang/sdk@5af9844 Language specification reorganization. dart-lang/sdk@2cb2ac4 Optimize `ClassHierarchyBuilder.isInheritedInSubtypeOf`. dart-lang/sdk@e8880fd Fix handling of unary- in the analyzer/FE comparison tool. dart-lang/sdk@bd103eb Store unlinked data with unlinked salt. dart-lang/sdk@c5d77d1 Support mixins in more places in index and search. dart-lang/sdk@c3bdb6c Refactor summary resynthesis tests in preparation for using the one-phase summary API. dart-lang/sdk@ddcb8b7 Remove unused SubtypeManager. dart-lang/sdk@76091c1 [vm/bytecode] Add PushNull, PushTrue, PushFalse and PushInt bytecodes dart-lang/sdk@a80b13e Add an assist to convert from a class to a mixin dart-lang/sdk@0f45b2e Fix spelling hexidecimal -> hexadecimal dart-lang/sdk@348ed30 [vm/kernel] In async transformation check if strongMode is on. dart-lang/sdk@c6c4748 [vm/bytecode] Bytecode compilation dart-lang/sdk@78d9a28 [vm, arm] Globally block LR for register allocation. dart-lang/sdk@078be2c [vm] Add library private key to the Class hash function for reload. dart-lang/sdk@4fab565 Several minor fixes to the analyzer/FE comparison tool. dart-lang/sdk@eb96871 Compute unlinked API signatures without unlinked summaries. dart-lang/sdk@98d25ed fix flutter#34450, implement boolean bitwise operators in dartdevc dart-lang/sdk@229d793 [vm/compiler] Support materializing unboxed variables when entering catch. dart-lang/sdk@eec96f9 [vm/kernel] Preserve strong mode types in async transformation dart-lang/sdk@bf4facd Handle errors when comparing analyzer and front end behaviors. dart-lang/sdk@3e9f4e6 dart2js: generate simple '==' in more cases
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart-lang/sdk@050561f [vm] Relax recently added assertion in Dart 1 mode
dart-lang/sdk@6c712f1 Add a fix to create a mixin
dart-lang/sdk@cc08d0e Add operators
&,|and^tobool.dart-lang/sdk@5af9844 Language specification reorganization.
dart-lang/sdk@2cb2ac4 Optimize
ClassHierarchyBuilder.isInheritedInSubtypeOf.dart-lang/sdk@e8880fd Fix handling of unary- in the analyzer/FE comparison tool.
dart-lang/sdk@bd103eb Store unlinked data with unlinked salt.
dart-lang/sdk@c5d77d1 Support mixins in more places in index and search.
dart-lang/sdk@c3bdb6c Refactor summary resynthesis tests in preparation for using the one-phase summary API.
dart-lang/sdk@ddcb8b7 Remove unused SubtypeManager.
dart-lang/sdk@76091c1 [vm/bytecode] Add PushNull, PushTrue, PushFalse and PushInt bytecodes
dart-lang/sdk@a80b13e Add an assist to convert from a class to a mixin
dart-lang/sdk@0f45b2e Fix spelling hexidecimal -> hexadecimal
dart-lang/sdk@348ed30 [vm/kernel] In async transformation check if strongMode is on.
dart-lang/sdk@c6c4748 [vm/bytecode] Bytecode compilation
dart-lang/sdk@78d9a28 [vm, arm] Globally block LR for register allocation.
dart-lang/sdk@078be2c [vm] Add library private key to the Class hash function for reload.
dart-lang/sdk@4fab565 Several minor fixes to the analyzer/FE comparison tool.
dart-lang/sdk@eb96871 Compute unlinked API signatures without unlinked summaries.
dart-lang/sdk@98d25ed fix #34450, implement boolean bitwise operators in dartdevc
dart-lang/sdk@229d793 [vm/compiler] Support materializing unboxed variables when entering catch.
dart-lang/sdk@eec96f9 [vm/kernel] Preserve strong mode types in async transformation
dart-lang/sdk@bf4facd Handle errors when comparing analyzer and front end behaviors.
dart-lang/sdk@3e9f4e6 dart2js: generate simple '==' in more cases