Fix crash when removeViewImmediate invoked from platform view #6266

wsxyeah · 2018-09-15T11:17:52Z

Since removeViewImmediate method isn't handled by WindowManagerHandler,
the real WindowManager's removeViewImmediate will be invoked, which caused the crash.

Here is the crash stack trace:

09-15 19:08:21.513 32298-32298/? E/AndroidRuntime: FATAL EXCEPTION: main
    Process: xyz.wsxyeah.flutterplugindemoexample, PID: 32298
    java.lang.IllegalArgumentException: View=android.widget.PopupWindow$PopupDecorView{a54e7dd V.E...... R....... 288,528-393,633} not attached to window manager
        at android.view.WindowManagerGlobal.findViewLocked(WindowManagerGlobal.java:485)
        at android.view.WindowManagerGlobal.removeView(WindowManagerGlobal.java:394)
        at android.view.WindowManagerImpl.removeViewImmediate(WindowManagerImpl.java:124)
        at java.lang.reflect.Method.invoke(Native Method)
        at io.flutter.plugin.platform.SingleViewPresentation$WindowManagerHandler.invoke(SingleViewPresentation.java:274)
        at java.lang.reflect.Proxy.invoke(Proxy.java:1006)
        at $Proxy0.removeViewImmediate(Unknown Source)
        at android.widget.PopupWindow.dismissImmediate(PopupWindow.java:1987)
        at android.widget.PopupWindow.dismiss(PopupWindow.java:1930)
        at android.widget.Editor$HandleView.dismiss(Editor.java:4601)
        at android.widget.Editor$HandleView.hide(Editor.java:4606)
        at android.widget.Editor$InsertionPointCursorController.hide(Editor.java:5675)
        at android.widget.Editor.hideInsertionPointCursorController(Editor.java:743)
        at android.widget.Editor.refreshTextActionMode(Editor.java:2066)
        at android.widget.TextView.spanChange(TextView.java:9903)
        at android.widget.TextView$ChangeWatcher.onSpanChanged(TextView.java:12534)
        at android.text.SpannableStringBuilder.sendSpanChanged(SpannableStringBuilder.java:1303)
        at android.text.SpannableStringBuilder.setSpan(SpannableStringBuilder.java:750)
        at android.text.SpannableStringBuilder.setSpan(SpannableStringBuilder.java:674)
        at android.text.Selection.setSelection(Selection.java:95)
        at android.text.Selection.setSelection(Selection.java:77)
        at android.widget.Editor.selectCurrentWord(Editor.java:978)
        at android.widget.Editor.selectCurrentWordAndStartDrag(Editor.java:2182)
        at android.widget.Editor.performLongClick(Editor.java:1209)
        at android.widget.TextView.performLongClick(TextView.java:11346)
        at android.view.View.performLongClick(View.java:6653)
        at android.view.View$CheckForLongPress.run(View.java:25850)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:6669)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

googlebot · 2018-09-15T11:17:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot · 2018-09-15T11:17:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

wsxyeah · 2018-09-15T11:24:49Z

I signed it!

googlebot · 2018-09-15T11:24:51Z

CLAs look good, thanks!

googlebot · 2018-09-15T11:24:51Z

CLAs look good, thanks!

matthew-carroll · 2018-09-21T22:37:00Z

Can we get some context around this issue? What is the use-case in question?

mklim

Thanks for the contribution @wsxyeah!

Can we get some context around this issue? What is the use-case in question?

So my understanding is that SingleViewPresentation needs to override and intercept all of the WindowManager methods that involve altering the WM's view hierarchy. It manually attaches the views in question to SingleViewPresentation#mFakeWindowRootView to avoid crashing at certain edge cases. Some comments, original PR.

It looks like when those changes were originally added they didn't cover removeViewImmediate, so that method call still falls back to WindowManager itself. That's triggering an error now since the base class isn't tracking the hierarchy anymore: View=android.widget.PopupWindow$PopupDecorView{a54e7dd V.E...... R....... 288,528-393,633} not attached to window manager

/cc @amirh in case he can provide an extra insight to the original issue.

mklim · 2018-09-21T22:54:38Z

shell/platform/android/io/flutter/plugin/platform/SingleViewPresentation.java

+                return;
+            }
+            View view = (View) args[0];
+            mFakeWindowRootView.removeView(view);


This doesn't exactly emulate what the base removeViewImmediate does.

Special variation of ViewManager.removeView(View) that immediately invokes the given view hierarchy's View.onDetachedFromWindow() methods before returning.

Should this be calling onDetachedFromWindow()?

I just looked up the implementation of ViewGroup.removeView().

Iff view.getAnimation() != null || (mTransitioningViews != null && mTransitioningViews.contains(view)), the child's onDetachedFromWindow will not be called.
Since there's not transition set on mFakeWindowRootView, we can just consider call child's clearAnimation() to skip this case. That is to say, onDetachedFromWindow will always be called immediately.

shell/platform/android/io/flutter/plugin/platform/SingleViewPresentation.java

wsxyeah · 2018-09-22T01:55:01Z

Can we get some context around this issue? What is the use-case in question?

I wrapped a native TextView and enabled its text selectable. And when I long press the text for selection, then try to dismiss the selection cursor, I just got this crash.
As shown in the crash stack trace, WindowManager.removeViewImmediate will be invoked to dismiss the text selection cursor.

amirh

This is great! thank you for the fix.

I wonder if this also fixes flutter/flutter#21239

LGTM with a small nit.

amirh · 2018-09-22T03:13:50Z

shell/platform/android/io/flutter/plugin/platform/SingleViewPresentation.java

+                return;
+            }
+            View view = (View) args[0];
+            view.clearAnimation();


Do you know if clearAnimation is triggered when calling WindowManager.removeViewImmediate, and WindowManager.removeView we should probably be consistent with whatever WindowManager is doing.

Doesn't have to happen in this PR, feel free to just leave a:
// TODO(amirh): Make sure that the clearAnimation call in removeViewImmediate and removeView is consistent with WindowManager.
And I'll take a look when I'm bacl.

Sorry for the late reply.

As far as I know, WindowManager.removeViewImmediate will not trigger View.clearAnimation, but mCurrentAnimation of the view will be assigned to null when it's detached from window.

Clear animation is a workaround for remove view immediately, otherwise the view will not got removed synchronously.

mklim · 2018-09-24T16:40:26Z

LGTM as long as the comment from amirh@ is addressed. Thanks again!

chinmaygarde · 2018-10-15T22:58:52Z

@mklim Can we commit this? Clearing the PR queue.

flutter/engine@08272ee...26f437f git log 08272ee..26f437f --no-merges --oneline 26f437f Fix crash when removeViewImmediate invoked from platform view (flutter/engine#6266) aed6b8c Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (flutter/engine#6549) 3ba6270 Roll src/third_party/skia 921ec976556c..4b7b2ceb4ad9 (14 commits) (flutter/engine#6550) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@08272ee...2cd79d1 git log 08272ee..2cd79d1 --no-merges --oneline 2cd79d1 Roll src/third_party/skia 4b7b2ceb4ad9..b3067e8e1b6e (1 commits) (flutter/engine#6551) 62cd86c Advertise iOS Observatory port over mDNS/Bonjour (flutter/engine#6533) 26f437f Fix crash when removeViewImmediate invoked from platform view (flutter/engine#6266) aed6b8c Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (flutter/engine#6549) 3ba6270 Roll src/third_party/skia 921ec976556c..4b7b2ceb4ad9 (14 commits) (flutter/engine#6550) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@08272ee...126e61d git log 08272ee..126e61d --no-merges --oneline 126e61d Roll src/third_party/skia b3067e8e1b6e..198b87e5be20 (2 commits) (flutter/engine#6553) 2cd79d1 Roll src/third_party/skia 4b7b2ceb4ad9..b3067e8e1b6e (1 commits) (flutter/engine#6551) 62cd86c Advertise iOS Observatory port over mDNS/Bonjour (flutter/engine#6533) 26f437f Fix crash when removeViewImmediate invoked from platform view (flutter/engine#6266) aed6b8c Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (flutter/engine#6549) 3ba6270 Roll src/third_party/skia 921ec976556c..4b7b2ceb4ad9 (14 commits) (flutter/engine#6550) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@08272ee...2dbbb2a git log 08272ee..2dbbb2a --no-merges --oneline 2dbbb2a Roll src/third_party/skia 198b87e5be20..a583a06f831e (5 commits) (flutter/engine#6554) 126e61d Roll src/third_party/skia b3067e8e1b6e..198b87e5be20 (2 commits) (flutter/engine#6553) 2cd79d1 Roll src/third_party/skia 4b7b2ceb4ad9..b3067e8e1b6e (1 commits) (flutter/engine#6551) 62cd86c Advertise iOS Observatory port over mDNS/Bonjour (flutter/engine#6533) 26f437f Fix crash when removeViewImmediate invoked from platform view (flutter/engine#6266) aed6b8c Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (flutter/engine#6549) 3ba6270 Roll src/third_party/skia 921ec976556c..4b7b2ceb4ad9 (14 commits) (flutter/engine#6550) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@08272ee...fc376dd git log 08272ee..fc376dd --no-merges --oneline fc376dd Roll src/third_party/skia a583a06f831e..1349ec4de78c (1 commits) (flutter/engine#6555) 2dbbb2a Roll src/third_party/skia 198b87e5be20..a583a06f831e (5 commits) (flutter/engine#6554) 126e61d Roll src/third_party/skia b3067e8e1b6e..198b87e5be20 (2 commits) (flutter/engine#6553) 2cd79d1 Roll src/third_party/skia 4b7b2ceb4ad9..b3067e8e1b6e (1 commits) (flutter/engine#6551) 62cd86c Advertise iOS Observatory port over mDNS/Bonjour (flutter/engine#6533) 26f437f Fix crash when removeViewImmediate invoked from platform view (flutter/engine#6266) aed6b8c Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (flutter/engine#6549) 3ba6270 Roll src/third_party/skia 921ec976556c..4b7b2ceb4ad9 (14 commits) (flutter/engine#6550) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@08272ee...215c146 git log 08272ee..215c146 --no-merges --oneline 215c146 Roll src/third_party/skia 1349ec4de78c..3d99b1e347be (3 commits) (flutter/engine#6556) fc376dd Roll src/third_party/skia a583a06f831e..1349ec4de78c (1 commits) (flutter/engine#6555) 2dbbb2a Roll src/third_party/skia 198b87e5be20..a583a06f831e (5 commits) (flutter/engine#6554) 126e61d Roll src/third_party/skia b3067e8e1b6e..198b87e5be20 (2 commits) (flutter/engine#6553) 2cd79d1 Roll src/third_party/skia 4b7b2ceb4ad9..b3067e8e1b6e (1 commits) (flutter/engine#6551) 62cd86c Advertise iOS Observatory port over mDNS/Bonjour (flutter/engine#6533) 26f437f Fix crash when removeViewImmediate invoked from platform view (flutter/engine#6266) aed6b8c Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (flutter/engine#6549) 3ba6270 Roll src/third_party/skia 921ec976556c..4b7b2ceb4ad9 (14 commits) (flutter/engine#6550) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@08272ee...df5f420 git log 08272ee..df5f420 --no-merges --oneline df5f420 Roll src/third_party/skia 3d99b1e347be..c9092eb46754 (10 commits) (flutter/engine#6559) 215c146 Roll src/third_party/skia 1349ec4de78c..3d99b1e347be (3 commits) (flutter/engine#6556) fc376dd Roll src/third_party/skia a583a06f831e..1349ec4de78c (1 commits) (flutter/engine#6555) 2dbbb2a Roll src/third_party/skia 198b87e5be20..a583a06f831e (5 commits) (flutter/engine#6554) 126e61d Roll src/third_party/skia b3067e8e1b6e..198b87e5be20 (2 commits) (flutter/engine#6553) 2cd79d1 Roll src/third_party/skia 4b7b2ceb4ad9..b3067e8e1b6e (1 commits) (flutter/engine#6551) 62cd86c Advertise iOS Observatory port over mDNS/Bonjour (flutter/engine#6533) 26f437f Fix crash when removeViewImmediate invoked from platform view (flutter/engine#6266) aed6b8c Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (flutter/engine#6549) 3ba6270 Roll src/third_party/skia 921ec976556c..4b7b2ceb4ad9 (14 commits) (flutter/engine#6550) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

@animation

flutter/engine@08272ee...04c860f git log 08272ee..04c860f --no-merges --oneline 04c860f Revert "Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (flutter#6549)" (flutter/engine#6568) ef2ea12 Roll src/third_party/skia 5b90b84085cf..cb65ce7f77c9 (8 commits) (flutter/engine#6567) 065246e Roll src/third_party/skia 483536c242f3..5b90b84085cf (3 commits) (flutter/engine#6566) b0008ca Roll src/third_party/skia 583161c09a3b..483536c242f3 (2 commits) (flutter/engine#6565) e22da7c Roll src/third_party/skia 0a8faf3f557d..583161c09a3b (1 commits) (flutter/engine#6564) 915f5e0 Roll src/third_party/skia f831b64ed40e..0a8faf3f557d (5 commits) (flutter/engine#6563) ad0fbd5 Roll src/third_party/skia c9092eb46754..f831b64ed40e (14 commits) (flutter/engine#6561) 6697d9d Update @animation dartdoc directives to current api (flutter/engine#6552) 10f9cab Ensure that the platform view is created and destroyed when running the shell unittests. (flutter/engine#6560) df5f420 Roll src/third_party/skia 3d99b1e347be..c9092eb46754 (10 commits) (flutter/engine#6559) 215c146 Roll src/third_party/skia 1349ec4de78c..3d99b1e347be (3 commits) (flutter/engine#6556) fc376dd Roll src/third_party/skia a583a06f831e..1349ec4de78c (1 commits) (flutter/engine#6555) 2dbbb2a Roll src/third_party/skia 198b87e5be20..a583a06f831e (5 commits) (flutter/engine#6554) 126e61d Roll src/third_party/skia b3067e8e1b6e..198b87e5be20 (2 commits) (flutter/engine#6553) 2cd79d1 Roll src/third_party/skia 4b7b2ceb4ad9..b3067e8e1b6e (1 commits) (flutter/engine#6551) 62cd86c Advertise iOS Observatory port over mDNS/Bonjour (flutter/engine#6533) 26f437f Fix crash when removeViewImmediate invoked from platform view (flutter/engine#6266) aed6b8c Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (flutter/engine#6549) 3ba6270 Roll src/third_party/skia 921ec976556c..4b7b2ceb4ad9 (14 commits) (flutter/engine#6550) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

@animation

flutter/engine@08272ee...04c860f git log 08272ee..04c860f --no-merges --oneline 04c860f Revert "Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (#6549)" (flutter/engine#6568) ef2ea12 Roll src/third_party/skia 5b90b84085cf..cb65ce7f77c9 (8 commits) (flutter/engine#6567) 065246e Roll src/third_party/skia 483536c242f3..5b90b84085cf (3 commits) (flutter/engine#6566) b0008ca Roll src/third_party/skia 583161c09a3b..483536c242f3 (2 commits) (flutter/engine#6565) e22da7c Roll src/third_party/skia 0a8faf3f557d..583161c09a3b (1 commits) (flutter/engine#6564) 915f5e0 Roll src/third_party/skia f831b64ed40e..0a8faf3f557d (5 commits) (flutter/engine#6563) ad0fbd5 Roll src/third_party/skia c9092eb46754..f831b64ed40e (14 commits) (flutter/engine#6561) 6697d9d Update @animation dartdoc directives to current api (flutter/engine#6552) 10f9cab Ensure that the platform view is created and destroyed when running the shell unittests. (flutter/engine#6560) df5f420 Roll src/third_party/skia 3d99b1e347be..c9092eb46754 (10 commits) (flutter/engine#6559) 215c146 Roll src/third_party/skia 1349ec4de78c..3d99b1e347be (3 commits) (flutter/engine#6556) fc376dd Roll src/third_party/skia a583a06f831e..1349ec4de78c (1 commits) (flutter/engine#6555) 2dbbb2a Roll src/third_party/skia 198b87e5be20..a583a06f831e (5 commits) (flutter/engine#6554) 126e61d Roll src/third_party/skia b3067e8e1b6e..198b87e5be20 (2 commits) (flutter/engine#6553) 2cd79d1 Roll src/third_party/skia 4b7b2ceb4ad9..b3067e8e1b6e (1 commits) (flutter/engine#6551) 62cd86c Advertise iOS Observatory port over mDNS/Bonjour (flutter/engine#6533) 26f437f Fix crash when removeViewImmediate invoked from platform view (flutter/engine#6266) aed6b8c Roll Dart to ac6d4f7e653deba11d4836768376537893a9e9d6. (flutter/engine#6549) 3ba6270 Roll src/third_party/skia 921ec976556c..4b7b2ceb4ad9 (14 commits) (flutter/engine#6550) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

googlebot added the cla: no label Sep 15, 2018

googlebot added cla: yes and removed cla: no labels Sep 15, 2018

chinmaygarde requested review from matthew-carroll and mklim September 21, 2018 19:30

mklim suggested changes Sep 21, 2018

View reviewed changes

wsxyeah added 2 commits September 22, 2018 10:34

Fix crash when removeViewImmediate invoked from platform view

667aa6b

Clear animation before remove view from mFakeWindowRootView

1d9c291

wsxyeah force-pushed the fix/crash_remove_view_immediate branch from 664a6b9 to 1d9c291 Compare September 22, 2018 02:37

amirh reviewed Sep 22, 2018

View reviewed changes

mklim approved these changes Sep 24, 2018

View reviewed changes

mklim merged commit 26f437f into flutter:master Oct 15, 2018

engine-flutter-autoroll mentioned this pull request Oct 16, 2018

Roll engine 08272ee6aa33..26f437f377b2 (3 commits) flutter/flutter#23133

Closed

engine-flutter-autoroll mentioned this pull request Oct 16, 2018

Roll engine 08272ee6aa33..2cd79d14a0c0 (5 commits) flutter/flutter#23134

Closed

engine-flutter-autoroll mentioned this pull request Oct 16, 2018

Roll engine 08272ee6aa33..126e61d34cf8 (6 commits) flutter/flutter#23138

Closed

This was referenced Oct 16, 2018

Roll engine 08272ee6aa33..2dbbb2a9a733 (7 commits) flutter/flutter#23146

Closed

Roll engine 08272ee6aa33..fc376dd53033 (8 commits) flutter/flutter#23158

Closed

engine-flutter-autoroll mentioned this pull request Oct 16, 2018

Roll engine 08272ee6aa33..215c14694b9d (9 commits) flutter/flutter#23163

Closed

This was referenced Oct 16, 2018

Roll engine 08272ee6aa33..df5f4207ab0d (10 commits) flutter/flutter#23177

Closed

Roll engine 08272ee6aa33..04c860fa1dba (19 commits) flutter/flutter#23219

Merged

Fix crash when removeViewImmediate invoked from platform view #6266

Fix crash when removeViewImmediate invoked from platform view #6266

Uh oh!

Conversation

wsxyeah commented Sep 15, 2018

Uh oh!

googlebot commented Sep 15, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

googlebot commented Sep 15, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

wsxyeah commented Sep 15, 2018

Uh oh!

googlebot commented Sep 15, 2018

Uh oh!

googlebot commented Sep 15, 2018

Uh oh!

matthew-carroll commented Sep 21, 2018

Uh oh!

mklim left a comment

Choose a reason for hiding this comment

Uh oh!

mklim Sep 21, 2018

Choose a reason for hiding this comment

Uh oh!

wsxyeah Sep 22, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wsxyeah commented Sep 22, 2018

Uh oh!

amirh left a comment

Choose a reason for hiding this comment

Uh oh!

amirh Sep 22, 2018

Choose a reason for hiding this comment

Uh oh!

wsxyeah Oct 10, 2018

Choose a reason for hiding this comment

Uh oh!

mklim commented Sep 24, 2018

Uh oh!

chinmaygarde commented Oct 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants