This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix the frontend_server test #6261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
liyuqian
approved these changes
Sep 14, 2018
aam
approved these changes
Sep 14, 2018
Member
aam
left a comment
aam
left a comment
There was a problem hiding this comment.
We were running ci/test.sh in dart1 mode all this time then?
Contributor
|
It looks like Dart 2 to me: https://github.com/flutter/engine/blob/master/ci/docker/build/Dockerfile#L22 , or is there a flag to force Dart 1 even if the Dart has version 2.0.xxx? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 17, 2018
flutter/engine@1b2a207...b0b19d6 git log 1b2a207..b0b19d6 --no-merges --oneline b0b19d6 Fix the frontend_server test (flutter/engine#6261) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 17, 2018
flutter/engine@1b2a207...b0b19d6 git log 1b2a207..b0b19d6 --no-merges --oneline b0b19d6 Fix the frontend_server test (flutter/engine#6261) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.