This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. #6028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e constructor access the VM object. The service isolate creation callback may occur on a background thread before the call the Dart_Initialize within the DartVM construtor can finish. We store pointers to various snapshots within the DartVM object. These snapshots are necessary for to successfully create the service isolate. The isolate creation callback access the global object within the ForProcessIfInitialized method. This method can return null if the VM object has not been initialized. This leads to the service protocol failing to start in a non-deterministic manner. This patch moves the creation and access of the DartVM object within a critical section.
jason-simmons
approved these changes
Aug 15, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2018
flutter/engine@e3687f7...2f19645 git log e3687f7..2f19645 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-15 [email protected] Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. (flutter/engine#6028) 2018-08-15 [email protected] Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026) 2018-08-15 37626415+[email protected] Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027) 2018-08-15 [email protected] Update docker image tag and README (flutter/engine#5995) 2018-08-15 [email protected] Add message encoding/decoding utility to FML. (flutter/engine#6017) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2018
flutter/engine@e3687f7...36aa0ed git log e3687f7..36aa0ed --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-15 37626415+[email protected] Roll src/third_party/skia e49966c983ec..77af386c13cb (3 commits) (flutter/engine#6029) 2018-08-15 [email protected] Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. (flutter/engine#6028) 2018-08-15 [email protected] Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026) 2018-08-15 37626415+[email protected] Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027) 2018-08-15 [email protected] Update docker image tag and README (flutter/engine#5995) 2018-08-15 [email protected] Add message encoding/decoding utility to FML. (flutter/engine#6017) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2018
flutter/engine@e3687f7...3280fc3 git log e3687f7..3280fc3 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-15 37626415+[email protected] Roll src/third_party/skia 77af386c13cb..64703d11a92a (1 commits) (flutter/engine#6030) 2018-08-15 37626415+[email protected] Roll src/third_party/skia e49966c983ec..77af386c13cb (3 commits) (flutter/engine#6029) 2018-08-15 [email protected] Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. (flutter/engine#6028) 2018-08-15 [email protected] Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026) 2018-08-15 37626415+[email protected] Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027) 2018-08-15 [email protected] Update docker image tag and README (flutter/engine#5995) 2018-08-15 [email protected] Add message encoding/decoding utility to FML. (flutter/engine#6017) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2018
flutter/engine@e3687f7...a5204c9 git log e3687f7..a5204c9 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-16 37626415+[email protected] Roll src/third_party/skia 64703d11a92a..767fddfcce61 (1 commits) (flutter/engine#6031) 2018-08-15 37626415+[email protected] Roll src/third_party/skia 77af386c13cb..64703d11a92a (1 commits) (flutter/engine#6030) 2018-08-15 37626415+[email protected] Roll src/third_party/skia e49966c983ec..77af386c13cb (3 commits) (flutter/engine#6029) 2018-08-15 [email protected] Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. (flutter/engine#6028) 2018-08-15 [email protected] Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026) 2018-08-15 37626415+[email protected] Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027) 2018-08-15 [email protected] Update docker image tag and README (flutter/engine#5995) 2018-08-15 [email protected] Add message encoding/decoding utility to FML. (flutter/engine#6017) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Aug 16, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 16, 2018
flutter/engine@e3687f7...4ee6489 git log e3687f7..4ee6489 --date=short --no-merges --format='%%ad %%ae %%s' 2018-08-16 37626415+[email protected] Roll src/third_party/skia 767fddfcce61..cbd83bbd77d1 (1 commits) (flutter/engine#6032) 2018-08-16 37626415+[email protected] Roll src/third_party/skia 64703d11a92a..767fddfcce61 (1 commits) (flutter/engine#6031) 2018-08-15 37626415+[email protected] Roll src/third_party/skia 77af386c13cb..64703d11a92a (1 commits) (flutter/engine#6030) 2018-08-15 37626415+[email protected] Roll src/third_party/skia e49966c983ec..77af386c13cb (3 commits) (flutter/engine#6029) 2018-08-15 [email protected] Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. (flutter/engine#6028) 2018-08-15 [email protected] Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026) 2018-08-15 37626415+[email protected] Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027) 2018-08-15 [email protected] Update docker image tag and README (flutter/engine#5995) 2018-08-15 [email protected] Add message encoding/decoding utility to FML. (flutter/engine#6017) The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service isolate creation callback may occur on a background thread before
the call the Dart_Initialize within the DartVM construtor can finish. We store
pointers to various snapshots within the DartVM object. These snapshots are
necessary for to successfully create the service isolate. The isolate creation
callback access the global object within the ForProcessIfInitialized method.
This method can return null if the VM object has not been initialized. This
leads to the service protocol failing to start in a non-deterministic manner.
This patch moves the creation and access of the DartVM object within a critical
section.