Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Detach the resource context before shutting down the IO thread #6009

Merged
jason-simmons merged 1 commit into from
Aug 14, 2018
Merged

Detach the resource context before shutting down the IO thread #6009

jason-simmons merged 1 commit into from
Aug 14, 2018

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Aug 14, 2018

No description provided.

@jason-simmons
Copy link
Member Author

jason-simmons commented Aug 14, 2018

@chinmaygarde

chinmaygarde
chinmaygarde suggested changes Aug 14, 2018
View reviewed changes
shell/platform/android/android_shell_holder.cc Outdated
}

AndroidShellHolder::~AndroidShellHolder() {
if (platform_view_) {
Copy link
Member

@chinmaygarde chinmaygarde Aug 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platform view may not have a surface. This may happen in cases of shell termination before the platform view gets a surface. That is not to say that you can just perform a null surface check here however. As a surface could have been obtained after the task was posted. For this reason, I don't this this the right spot to clear the resource context.

Copy link
Member

@chinmaygarde chinmaygarde Aug 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just like CreateResourceContext on PlatformView, we can have a DestroyResourceContext. Currently, the resource context is create when the IO manager is setup (on the IO thread). We know that the IO manager will be collected on the IO thread, so lets collect the resource context at that moment as well. We wont have to deal with timing issues as those have already been sorted out for the IO manager. Also, we will get the exact same behavior on all platforms (though not all need it apparently).

Copy link
Member Author

@jason-simmons jason-simmons Aug 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this task up to the PlatformView. PTAL

@jason-simmons jason-simmons merged commit ea07f27 into flutter:master Aug 14, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..d038970 (36 commits)
586c3ed 
flutter/engine@e54bc4e...d038970

git log e54bc4e..d038970 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-14 [email protected] Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 [email protected] Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 [email protected] Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+[email protected] Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 [email protected] Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+[email protected] Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 [email protected] Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+[email protected] Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 [email protected] Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 [email protected] Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 [email protected] Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+[email protected] Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+[email protected] Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+[email protected] Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+[email protected] Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+[email protected] Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 [email protected] Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 [email protected] Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 [email protected] Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+[email protected] Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 [email protected] Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 [email protected] Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 [email protected] Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 [email protected] Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 [email protected] Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 [email protected] Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 [email protected] Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 [email protected] Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..69510ab (37 commits)
5868a2d 
flutter/engine@e54bc4e...69510ab

git log e54bc4e..69510ab --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 37626415+[email protected] Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 [email protected] Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 [email protected] Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 [email protected] Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+[email protected] Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 [email protected] Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+[email protected] Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 [email protected] Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+[email protected] Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 [email protected] Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 [email protected] Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 [email protected] Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+[email protected] Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+[email protected] Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+[email protected] Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+[email protected] Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+[email protected] Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 [email protected] Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 [email protected] Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 [email protected] Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+[email protected] Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 [email protected] Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 [email protected] Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 [email protected] Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 [email protected] Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 [email protected] Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 [email protected] Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 [email protected] Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 [email protected] Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..ad5af2f (38 commits)
48fd8ee 
flutter/engine@e54bc4e...ad5af2f

git log e54bc4e..ad5af2f --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 37626415+[email protected] Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 [email protected] Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 [email protected] Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 [email protected] Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+[email protected] Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 [email protected] Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+[email protected] Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 [email protected] Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+[email protected] Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 [email protected] Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 [email protected] Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 [email protected] Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+[email protected] Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+[email protected] Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+[email protected] Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+[email protected] Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+[email protected] Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 [email protected] Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 [email protected] Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 [email protected] Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+[email protected] Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 [email protected] Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 [email protected] Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 [email protected] Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 [email protected] Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 [email protected] Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 [email protected] Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 [email protected] Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 [email protected] Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..81baff9 (39 commits)
cd1c74e 
flutter/engine@e54bc4e...81baff9

git log e54bc4e..81baff9 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 [email protected] Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 [email protected] Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 [email protected] Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 [email protected] Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+[email protected] Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 [email protected] Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+[email protected] Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 [email protected] Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+[email protected] Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 [email protected] Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 [email protected] Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 [email protected] Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+[email protected] Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+[email protected] Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+[email protected] Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+[email protected] Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+[email protected] Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 [email protected] Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 [email protected] Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 [email protected] Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+[email protected] Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 [email protected] Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 [email protected] Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 [email protected] Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 [email protected] Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 [email protected] Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 [email protected] Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 [email protected] Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 [email protected] Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..e3687f7 (40 commits)
5c6716a 
flutter/engine@e54bc4e...e3687f7

git log e54bc4e..e3687f7 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 37626415+[email protected] Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025)
2018-08-15 [email protected] Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 [email protected] Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 [email protected] Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 [email protected] Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+[email protected] Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 [email protected] Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+[email protected] Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 [email protected] Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+[email protected] Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 [email protected] Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 [email protected] Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 [email protected] Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+[email protected] Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+[email protected] Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+[email protected] Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+[email protected] Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+[email protected] Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 [email protected] Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 [email protected] Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 [email protected] Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+[email protected] Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 [email protected] Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 [email protected] Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 [email protected] Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 [email protected] Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 [email protected] Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 [email protected] Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 [email protected] Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 [email protected] Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..7e39999 (41 commits)
2e7d937 
flutter/engine@e54bc4e...7e39999

git log e54bc4e..7e39999 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 [email protected] Add message encoding/decoding utility to FML. (flutter/engine#6017)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025)
2018-08-15 [email protected] Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 [email protected] Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 [email protected] Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 [email protected] Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+[email protected] Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 [email protected] Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+[email protected] Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 [email protected] Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+[email protected] Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 [email protected] Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 [email protected] Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 [email protected] Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+[email protected] Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+[email protected] Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+[email protected] Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+[email protected] Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+[email protected] Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 [email protected] Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 [email protected] Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 [email protected] Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+[email protected] Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 [email protected] Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 [email protected] Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 [email protected] Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 [email protected] Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 [email protected] Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 [email protected] Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 [email protected] Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 [email protected] Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..829e475 (42 commits)
dc7c268 
flutter/engine@e54bc4e...829e475

git log e54bc4e..829e475 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 [email protected] Update docker image tag and README (flutter/engine#5995)
2018-08-15 [email protected] Add message encoding/decoding utility to FML. (flutter/engine#6017)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025)
2018-08-15 [email protected] Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 [email protected] Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 [email protected] Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 [email protected] Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+[email protected] Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 [email protected] Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+[email protected] Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 [email protected] Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+[email protected] Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 [email protected] Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 [email protected] Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 [email protected] Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+[email protected] Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+[email protected] Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+[email protected] Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+[email protected] Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+[email protected] Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 [email protected] Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 [email protected] Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 [email protected] Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+[email protected] Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 [email protected] Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 [email protected] Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 [email protected] Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 [email protected] Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 [email protected] Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 [email protected] Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 [email protected] Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 [email protected] Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..c09116a (43 commits)
e9eb3c7 
flutter/engine@e54bc4e...c09116a

git log e54bc4e..c09116a --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 37626415+[email protected] Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027)
2018-08-15 [email protected] Update docker image tag and README (flutter/engine#5995)
2018-08-15 [email protected] Add message encoding/decoding utility to FML. (flutter/engine#6017)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025)
2018-08-15 [email protected] Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 [email protected] Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 [email protected] Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 [email protected] Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+[email protected] Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 [email protected] Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+[email protected] Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 [email protected] Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+[email protected] Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 [email protected] Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 [email protected] Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 [email protected] Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+[email protected] Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+[email protected] Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+[email protected] Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+[email protected] Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+[email protected] Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 [email protected] Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 [email protected] Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 [email protected] Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+[email protected] Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 [email protected] Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 [email protected] Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 [email protected] Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 [email protected] Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 [email protected] Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 [email protected] Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 [email protected] Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 [email protected] Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2018
@engine-flutter-autoroll
Roll engine e54bc4e..9c0c620 (44 commits)
829e944 
flutter/engine@e54bc4e...9c0c620

git log e54bc4e..9c0c620 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15 [email protected] Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027)
2018-08-15 [email protected] Update docker image tag and README (flutter/engine#5995)
2018-08-15 [email protected] Add message encoding/decoding utility to FML. (flutter/engine#6017)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 916c498c04fa..31a0944bb30b (3 commits) (flutter/engine#6025)
2018-08-15 [email protected] Switch all embedders to use platform_strong.dill instead of platform.dill (the flutter_tester binary already does this) (flutter/engine#6024)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 49bb9c17d713..916c498c04fa (1 commits) (flutter/engine#6023)
2018-08-15 37626415+[email protected] Roll src/third_party/skia 572eee09ef71..49bb9c17d713 (1 commits) (flutter/engine#6022)
2018-08-14 [email protected] Revert "Log Tonic errors with FML_LOG" (flutter/engine#6021)
2018-08-14 [email protected] Fix Android Vulkan builds to account for resource context management API updates. (flutter/engine#6020)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 0d4a18321160..572eee09ef71 (3 commits) (flutter/engine#6019)
2018-08-14 [email protected] Log Tonic errors with FML_LOG (flutter/engine#6015)
2018-08-14 37626415+[email protected] Roll src/third_party/skia cdbb076bf577..0d4a18321160 (5 commits) (flutter/engine#6016)
2018-08-14 [email protected] Detach the resource context before shutting down the IO thread (flutter/engine#6009)
2018-08-14 37626415+[email protected] Roll src/third_party/skia 32c7d4dfcdca..cdbb076bf577 (5 commits) (flutter/engine#6014)
2018-08-15 1751188+[email protected] Add NSNull check in setSystemChromeSystemUIOverlayStyle (flutter/engine#6011)
2018-08-14 [email protected] Don't require `FLTLibraryPath` and `FLTAssetsPath` from the main `NSBundle` (flutter/engine#5986)
2018-08-14 37626415+[email protected] Roll src/third_party/skia d4322a8630bc..32c7d4dfcdca (2 commits) (flutter/engine#6013)
2018-08-14 [email protected] Widen sdk version constraint of package:{flutter_services,sky_engine,sky_services} to allow ^2.0.0 (flutter/engine#6012)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 1b95ef9f9912..d4322a8630bc (1 commits) (flutter/engine#6010)
2018-08-13 [email protected] Do not log unwind errors during isolate shutdown (flutter/engine#6008)
2018-08-13 [email protected] Remove unused argument on Animator, Engine and PlatformView delegates. (flutter/engine#6007)
2018-08-13 37626415+[email protected] Roll src/third_party/skia beac4195ccb7..1b95ef9f9912 (1 commits) (flutter/engine#6006)
2018-08-13 37626415+[email protected] Roll src/third_party/skia b35c655378ee..beac4195ccb7 (6 commits) (flutter/engine#6005)
2018-08-13 37626415+[email protected] Roll src/third_party/skia 87a737292804..b35c655378ee (1 commits) (flutter/engine#6004)
2018-08-13 37626415+[email protected] Roll src/third_party/skia f1a25c06cd15..87a737292804 (1 commits) (flutter/engine#6003)
2018-08-12 37626415+[email protected] Roll src/third_party/skia 02d174687cc9..f1a25c06cd15 (1 commits) (flutter/engine#6002)
2018-08-11 37626415+[email protected] Roll src/third_party/skia 5fb1b7e0ffe1..02d174687cc9 (1 commits) (flutter/engine#6001)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 609fbe34de01..5fb1b7e0ffe1 (3 commits) (flutter/engine#6000)
2018-08-10 [email protected] Make 'gn --debug' and 'gn --debug --dynamic' identical. (flutter/engine#5999)
2018-08-10 [email protected] Enable VK_KHR_get_physical_device_properties2 (flutter/engine#5982)
2018-08-10 [email protected] Add VK_ERROR_FRAGMENTATION_EXT (flutter/engine#5981)
2018-08-10 37626415+[email protected] Roll src/third_party/skia a9660ec89bc7..609fbe34de01 (7 commits) (flutter/engine#5998)
2018-08-10 [email protected] Check the kernel header magic to determine if a mapping may be a valid kernel blob. (flutter/engine#5997)
2018-08-10 [email protected] Add a delay to Animator::BeginFrame's NotifyIdle call (flutter/engine#5972)
2018-08-10 [email protected] Fix codepush breakage caused by flutter#5954. (flutter/engine#5996)
2018-08-10 [email protected] Cast MotionEvent timestamps to Number. (flutter/engine#5994)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 6ed63968a391..a9660ec89bc7 (14 commits) (flutter/engine#5993)
2018-08-10 [email protected] Reference platform_strong.dill, not platform.dill (flutter/engine#5992)
2018-08-10 [email protected] Update to FreeType 2.9.1 (flutter/engine#5991)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 5b5d84cc1f37..6ed63968a391 (4 commits) (flutter/engine#5989)
2018-08-10 37626415+[email protected] Roll src/third_party/skia 0d5d0659a684..5b5d84cc1f37 (39 commits) (flutter/engine#5988)
2018-08-10 [email protected] Roll Dart to version be6309690fd60284a87f3258a740c7c30efb1092 (flutter/engine#5987)
2018-08-09 [email protected] Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9 (flutter/engine#5985)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jason-simmons @chinmaygarde @googlebot