This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Deprecate -[FlutterDartProject initFromDefaultSourceForConfiguration] (#18886) #5858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#18886) `-[FlutterDartProject initFromDefaultSourceForConfiguration]` no longer seems very useful. It calls `-initWithPrecompiledDartBundle:` or `-initWithFlutterAssets:dartMain:packages:`, but since it now passes `nil` for all arguments, both paths end up doing the same thing. Additionally, `-initFromDefaultSourceForConfiguration` is awkward to use in Swift. The automatically generated Swift interface is: public convenience init!(fromDefaultSourceForConfiguration: ()) and it's not obvious how to call that. Let's deprecate `-initFromDefaultSourceForConfiguration` and instead expect callers to use the existing `-init` method. (We can make `-init` do different things for different build configurations later if necessary.) Bonus: Rename some parameters to make it more obvious when they may be `nil`.
Contributor
Author
|
I'm going to temporarily close and reopen this to try to get Travis to rerun its test. |
Contributor
chinmaygarde
approved these changes
Jul 30, 2018
Contributor
Author
|
BTW, I don't have commit access, so someone will need to merge my change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-[FlutterDartProject initFromDefaultSourceForConfiguration]nolonger seems very useful. It calls
-initWithPrecompiledDartBundle:or
-initWithFlutterAssets:dartMain:packages:, but since it nowpasses
nilfor all arguments, both paths end up doing the samething.
Additionally,
-initFromDefaultSourceForConfigurationis awkward touse in Swift. The automatically generated Swift interface is:
and it's not obvious how to call that.
Let's deprecate
-initFromDefaultSourceForConfigurationand insteadexpect callers to use the existing
-initmethod. (We can make-initdo different things for different build configurations laterif necessary.)
Bonus: Rename some parameters to make it more obvious when they may
be
nil.