This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP][Impeller] disable all Adrenos older than 640 (#57069) #57100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flutter/flutter#159834 Disable all older Adreno GPUs
zanderso
approved these changes
Dec 10, 2024
Contributor
Author
|
This should be working now. |
zanderso
reviewed
Dec 13, 2024
| EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 505")); | ||
| EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 504")); | ||
|
|
||
| EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 640")); |
Member
There was a problem hiding this comment.
Looks like 640 needs to go in the EXPECT_TRUE list.
Contributor
Author
There was a problem hiding this comment.
oops, good catch
itsjustkevin
added
the
autosubmit
auto-submit
bot
merged commit cb4b5ff
into
flutter:flutter-3.27-candidate.0
27 checks passed
jonahwilliams
changed the title
|
This is not yet on the current beta branch (3.28.0-0.1.pre). Could we get this cherry-picked there too? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick for flutter/flutter#160041