This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[engine] changes to DlVertices::Builder and Stopwatch visualizer. #57031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
reviewed
Dec 9, 2024
Contributor
flar
left a comment
flar
left a comment
There was a problem hiding this comment.
Mostly looks good, but is there really caching going on?
flow/stopwatch_dl.cc
Outdated
| auto const right = rect.GetRight(); | ||
| auto const bottom = rect.GetBottom(); | ||
|
|
||
| auto const vertices = std::array<DlPoint, 6>{ |
Contributor
There was a problem hiding this comment.
Why make an array only to immediately turn around and copy the values into the vectors one by one? This could just be 6 lines of "vector_[index_++] = next point".
Contributor
Author
There was a problem hiding this comment.
Yeah good point, let me swap that out.
| auto mutator = context.state_stack.save(); | ||
| // Cached storage for vertex output. | ||
| std::vector<DlPoint> vertices_storage; | ||
| std::vector<DlColor> color_storage; |
Contributor
There was a problem hiding this comment.
Weren't these supposed to be cached somewhere? It looks like they are recreated on every frame?
Contributor
There was a problem hiding this comment.
Or is this just re-use between the 2 graphs?
Contributor
Author
There was a problem hiding this comment.
Just between the two graphs. originally I was much more ambitious but it turns out that we rebuild the layer each frame so there isn't a good place to put the storage.
added 2 commits
December 11, 2024 11:47
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 11, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 11, 2024
…160126) flutter/engine@ba7ad87...b8034f1 2024-12-11 [email protected] Roll Dart SDK from be9c98daf9df to aa03dca5beb2 (1 revision) (flutter/engine#57136) 2024-12-11 [email protected] Make Felt unzip Chrome into a temporary directory next to the final location of the files (flutter/engine#57109) 2024-12-11 [email protected] [engine] changes to DlVertices::Builder and Stopwatch visualizer. (flutter/engine#57031) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…utter/engine#57031) Collection of changes to DlVertices::Builder and the stopwatch visualizer. At a high level: * improve performance of the stopwatch visualizer by pre-allocating storage (and sharing it across both visualizers), lookup up font once, and cache the debug frame rate used. Updates to use Dl types instead of SkTypes. * Change DlVerticesBuilder to allow storing the bounds and use that in the visualizer, since we already know them. Make FML_CHECKS into dchecks, as the dart:ui vertices will already bounds check correctly - so these should only be necessary for debugging engine changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of changes to DlVertices::Builder and the stopwatch visualizer.
At a high level:
improve performance of the stopwatch visualizer by pre-allocating storage (and sharing it across both visualizers), lookup up font once, and cache the debug frame rate used. Updates to use Dl types instead of SkTypes.
Change DlVerticesBuilder to allow storing the bounds and use that in the visualizer, since we already know them. Make FML_CHECKS into dchecks, as the dart:ui vertices will already bounds check correctly - so these should only be necessary for debugging engine changes.