This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[DisplayList] Delete (publicly) unused DlColorColorSource #56825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Apparently that file is not included in the golden test suite. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 27, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 27, 2024
…159523) flutter/engine@bd165dc...da71729 2024-11-27 [email protected] Roll Dart SDK from 72b594775c83 to 0740ded7b9bf (1 revision) (flutter/engine#56826) 2024-11-27 [email protected] Roll Fuchsia Linux SDK from 50xtjbMWWrqay_7m_... to u0agumUB4Ag6cTiKk... (flutter/engine#56823) 2024-11-27 [email protected] [DisplayList] Delete (publicly) unused DlColorColorSource (flutter/engine#56825) 2024-11-26 [email protected] [engine] reland: more consistently flush message loops tasks (flutter/engine#56815) 2024-11-26 [email protected] [Impeller] cache even more text frame data to skip lookups. (flutter/engine#56798) 2024-11-26 [email protected] [DisplayList] migrate DlColorFilter objects to new source layout (flutter/engine#56785) 2024-11-26 [email protected] Roll Dart SDK from ca02d403f1a8 to 72b594775c83 (1 revision) (flutter/engine#56819) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 50xtjbMWWrqa to u0agumUB4Ag6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…gine#56825) While recently updating the DlColorSource sources I noticed some questionably implementation choices in the Color variant of the color sources. I then realized that there was no public use of these classes (other than mostly their own unit tests) and so they should be deleted to focus on implementing the variants that are actually used by Flutter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While recently updating the DlColorSource sources I noticed some questionably implementation choices in the Color variant of the color sources.
I then realized that there was no public use of these classes (other than mostly their own unit tests) and so they should be deleted to focus on implementing the variants that are actually used by Flutter.