[web] Make sure to include all split fonts #56733
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| int familyCount = 0; | ||
| // Give each font shard a unique family name. | ||
| for (final Uri uri in uriCollector.uris) { | ||
| for (final match in r.allMatches(cssString)) { |
There was a problem hiding this comment.
Do we need to check that the match is a proper font URI? (like ending in known extensions or something?)
There was a problem hiding this comment.
Instead of doing that in the if, I'll make the regex more restrictive (i.e. starts with https?:// and ends with \.woff2).
There was a problem hiding this comment.
SGTM! Something I like to do when I write a complex RegEx is to create it here:
And save it (they support "Github login") with some Tests there. It's pretty fancy and IMO makes the regex explanation very legible!
(For example: https://regexr.com/88q3g)
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
mdebbar
added
the
autosubmit
…159270) flutter/engine@523d381...78b87f3 2024-11-21 [email protected] [web] Make sure to include all split fonts (flutter/engine#56733) 2024-11-21 [email protected] [web] Work around wrong pointerId in coalesced events in iOS Safari 18.2 (flutter/engine#56719) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The `csslib` parser was not reliably parsing all URLs in the CSS response. I'm switching to using a RegExp to extract all URLs reliably. Fixes flutter#159215
2 participants
The
csslibparser was not reliably parsing all URLs in the CSS response. I'm switching to using a RegExp to extract all URLs reliably.Fixes flutter/flutter#159215