This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] flush all GLES cmd buffers together. #56724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Nov 20, 2024
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
LGTM but I am not able to tell which operation guarantees a flush.
| render_pass->commands_, tracer); | ||
| FML_CHECK(result) << "Must be able to encode GL commands without error."; | ||
| }); | ||
| return reactor_->AddOperation( |
Member
There was a problem hiding this comment.
Whats the operation that finally enqueues a non-deferred operation? Is there guaranteed to be one? Otherwise, these operations will be pending in the reactor for a potentially long time.
I'm thinking of texture, pipeline, and perhaps blits also adding non-deferred operations. But nothing jumps out at being always present no matter what.
Contributor
Author
There was a problem hiding this comment.
CommandBuffer::Submit also performs a flush: https://github.com/flutter/engine/blob/main/impeller/renderer/backend/gles/command_buffer_gles.cc#L32-L38
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 20, 2024
…159214) flutter/engine@80d7750...3245c89 2024-11-20 [email protected] [Impeller] flush all GLES cmd buffers together. (flutter/engine#56724) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
|
Here is a good indicator of the benefit of this change, about 2x on our 90th percentile raster time |
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Locally this gives much better performance, about doubling frame time on the Pixel 4. This avoids multiple glbuffersubdata calls that seems to perform particularly bad on mobile devices. Thinking about it more, I'm not sure that having a separate EncodeCommands API is useful for RenderPass/BlitPass. instead they should probably just use submit. but that is a refactor for another day. flutter#159177
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally this gives much better performance, about doubling frame time on the Pixel 4. This avoids multiple glbuffersubdata calls that seems to perform particularly bad on mobile devices.
Thinking about it more, I'm not sure that having a separate EncodeCommands API is useful for RenderPass/BlitPass. instead they should probably just use submit. but that is a refactor for another day.
flutter/flutter#159177