This repository was archived by the owner on Feb 25, 2025. It is now read-only.
EmbedderTest: templatise GetEmbedderContext #56709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
requested review from
bdero,
chinmaygarde,
jonahwilliams and
loic-sharma
cbracken
commented
Nov 19, 2024
| TEST_F(EmbedderTest, TextureDestructionCallbackCalledWithoutCustomCompositorMetal) { | ||
| EmbedderTestContextMetal& context = reinterpret_cast<EmbedderTestContextMetal&>( | ||
| GetEmbedderContext(EmbedderTestContextType::kMetalContext)); | ||
| auto& context = GetEmbedderContext<EmbedderTestContextMetal>(); |
Member
Author
There was a problem hiding this comment.
Getting rid of the sort of cast in the old code was the goal here.
cbracken
commented
Nov 19, 2024
| template <> | ||
| EmbedderTestContextVulkan& GetEmbedderContext<EmbedderTestContextVulkan>() { | ||
| return reinterpret_cast<EmbedderTestContextVulkan&>(GetVulkanContext()); | ||
| } |
Member
Author
There was a problem hiding this comment.
Alright we still need some sneaky casts in the template specialisations here... but they're nice and hidden away.
cbracken
commented
Nov 19, 2024
In many embedder tests, we want to get at the appropriate backend-specific EmbedderTestContext subclass in order to make backend-specific setup calls such as `SetGLFBOCallback()` or others. Formerly, this required casting the returned EmbedderTestContext& to the appropriate subclass in each test. This templatises the GetEmbedderContext() method to return the appropriate backend-specific subclass directly. Issue: flutter/flutter#158998
cbracken
added
autosubmit
cbracken
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 19, 2024
…159168) flutter/engine@4ff696b...7eb8754 2024-11-19 [email protected] EmbedderTest: templatise GetEmbedderContext (flutter/engine#56709) 2024-11-19 [email protected] display_list: Extract backend-specific surface providers (flutter/engine#56711) 2024-11-19 [email protected] Roll Skia from 78ef6b7a574f to a694b9e85a49 (5 revisions) (flutter/engine#56713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
In many embedder tests, we want to get at the appropriate backend-specific `EmbedderTestContext` subclass (`EmbedderTestContextGL`, etc.) in order to make backend-specific setup calls such as `SetGLFBOCallback()` or others. Formerly, this required casting the returned `EmbedderTestContext&` to the appropriate subclass in each test. This templatises the `GetEmbedderContext()` method to return the appropriate backend-specific subclass directly. Issue: flutter#158998 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many embedder tests, we want to get at the appropriate backend-specific
EmbedderTestContextsubclass (EmbedderTestContextGL, etc.) in order to make backend-specific setup calls such asSetGLFBOCallback()or others. Formerly, this required casting the returnedEmbedderTestContext&to the appropriate subclass in each test.This templatises the
GetEmbedderContext()method to return the appropriate backend-specific subclass directly.Issue: flutter/flutter#158998
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.