Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[et] Add Android x64 configurations #56703

Merged
auto-submit merged 2 commits into from
Nov 20, 2024
Merged

[et] Add Android x64 configurations #56703

auto-submit merged 2 commits into from
Nov 20, 2024

Conversation

@dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Nov 19, 2024

@dcharkes
Copy link
Contributor Author

dcharkes commented Nov 19, 2024

android_debug_unopt_x64 works as expected.

android_debug fails for me locally though, but I can't spot what is wrong:

$ dart /usr/local/google/home/dacoharkes/flt/engine/src/flutter/tools/engine_tool/bin/et.dart build --rbe --gn-args=--no-prebuilt-dart-sdk --gn-args=--full-dart-sdk -c android_debug
[...]
Command failed: ./clang_x64/gen_snapshot --snapshot_kind=core --enable_mirrors=false --vm_snapshot_data=/usr/local/google/home/dacoharkes/flt/engine/src/out/android_debug/gen/flutter/lib/snapshot/vm_isolate_snapshot.bin --vm_snapshot_instructions=/usr/local/google/home/dacoharkes/flt/engine/src/out/android_debug/gen/flutter/lib/snapshot/vm_snapshot_instructions.bin --isolate_snapshot_data=/usr/local/google/home/dacoharkes/flt/engine/src/out/android_debug/gen/flutter/lib/snapshot/isolate_snapshot.bin --isolate_snapshot_instructions=/usr/local/google/home/dacoharkes/flt/engine/src/out/android_debug/gen/flutter/lib/snapshot/isolate_snapshot_instructions.bin /usr/local/google/home/dacoharkes/flt/engine/src/out/android_debug/flutter_patched_sdk/platform_strong.dill
exitCode: 254
Can't load Kernel binary: Invalid SDK hash.

@matanlurey
Copy link
Contributor

matanlurey commented Nov 19, 2024

android_debug fails for me locally though, but I can't spot what is wrong:

Looks like it fails on CI as well: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/2912804/overview.

@dcharkes
Copy link
Contributor Author

dcharkes commented Nov 20, 2024

android_debug fails for me locally though, but I can't spot what is wrong:

Looks like it fails on CI as well: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/2912804/overview.

Okay, I've removed the config. I only need one to test x64 Android emulators on Linux.

This is ready for review.

@matanlurey
Copy link
Contributor

matanlurey commented Nov 20, 2024

Thanks for the contribution!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 20, 2024
@auto-submit auto-submit bot merged commit 3828681 into main Nov 20, 2024
33 checks passed
@auto-submit auto-submit bot deleted the et-linux-android-x64-configs branch November 20, 2024 19:03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 20, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 20, 2024
@engine-flutter-autoroll
3828681d1 [et] Add Android x64 configurations (flutter/engine#56703)
b33f2c1
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 20, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 3245c8976976 to 3828681d1f86 (1 revision) (#…
53bd643 
…159217)

flutter/engine@3245c89...3828681

2024-11-20 [email protected] [et] Add Android x64 configurations
(flutter/engine#56703)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
@dcharkes
[et] Add Android x64 configurations (flutter/engine#56703)
a599b5e 
Closes: flutter#156598
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@johnmccutchan johnmccutchan Awaiting requested review from johnmccutchan

1 more reviewer

@matanlurey matanlurey matanlurey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[et] Build for android_x64 emulator on x64 host

2 participants

@dcharkes @matanlurey