This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add missing cancellable to text input handler #56666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this if a channel method call was in progress and then the handler was destroyed the call could attempt to access the destroyed handler. This is possible as the handler is recreated on engine restart. However, in this case the result is not used so no invalid memory access would occur. Adding the cancellable fixes any future change where this would no longer be the case.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Contributor
|
test-exempt: code refactor with no semantic change |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 19, 2024
…159134) flutter/engine@983b7b8...b6723e3 2024-11-19 [email protected] Roll Skia from 17601e471acf to 8a1a84509501 (4 revisions) (flutter/engine#56700) 2024-11-19 [email protected] Roll Skia from 8d652f142911 to 17601e471acf (1 revision) (flutter/engine#56696) 2024-11-19 [email protected] Add missing cancellable to text input handler (flutter/engine#56666) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Without this if a channel method call was in progress and then the handler was destroyed the call could attempt to access the destroyed handler. This is possible as the handler is recreated on engine restart. However, in this case the result is not used so no invalid memory access would occur. Adding the cancellable fixes any future change where this would no longer be the case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this if a channel method call was in progress and then the handler was destroyed the call could attempt to access the destroyed handler. This is possible as the handler is recreated on engine restart.
However, in this case the result is not used so no invalid memory access would occur. Adding the cancellable fixes any future change where this would no longer be the case.