This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Use updated gni source list #56627
Merged
Merged
Use updated gni source list #56627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
approved these changes
Nov 15, 2024
Contributor
flar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2024
…159078) flutter/engine@f365c9f...e1f4e7d 2024-11-18 [email protected] Roll Dart SDK from 8795a3eaa87b to ae5111067032 (1 revision) (flutter/engine#56675) 2024-11-18 [email protected] Roll Skia from 5968000526fe to 78fd0dfa6cf8 (1 revision) (flutter/engine#56674) 2024-11-18 [email protected] Use updated gni source list (flutter/engine#56627) 2024-11-18 [email protected] Roll Fuchsia Linux SDK from K-3yXpPmmu1f0idCa... to io00npG_eDCYC7bac... (flutter/engine#56673) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from K-3yXpPmmu1f to io00npG_eDCY If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
hubot
pushed a commit
to google/skia
that referenced
this pull request
Nov 18, 2024
Client CLs: - https://crrev.com/c/6031190 - flutter/engine#56627 PDFium used to use skcms_sources, but that was updated in https://pdfium-review.googlesource.com/c/pdfium/+/113670 Change-Id: I2b464d2bf5cd6cbba6f13bf72981e33da0e848bd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/920816 Reviewed-by: Eric Boren <[email protected]>
hubot
pushed a commit
to google/skia
that referenced
this pull request
Nov 19, 2024
This reverts commit 8d652f1. Reason for revert: A couple of Chrome builds still seem to be depending on skia_sksl_default_module_sources Original change's description: > Remove TODOs in GNI exporter tool > > Client CLs: > - https://crrev.com/c/6031190 > - flutter/engine#56627 > > PDFium used to use skcms_sources, but that was updated in > https://pdfium-review.googlesource.com/c/pdfium/+/113670 > > Change-Id: I2b464d2bf5cd6cbba6f13bf72981e33da0e848bd > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/920816 > Reviewed-by: Eric Boren <[email protected]> Change-Id: Ic03324f9b1b071d834c4cfccaabe1fb6b25d796b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/922196 Bot-Commit: Rubber Stamper <[email protected]> Auto-Submit: Robert Phillips <[email protected]> Commit-Queue: Robert Phillips <[email protected]> Commit-Queue: Rubber Stamper <[email protected]>
hubot
pushed a commit
to google/skia
that referenced
this pull request
Nov 19, 2024
Additional Client CLs: - https://pdfium-review.googlesource.com/c/pdfium/+/126290 - https://crrev.com/i/7837550 This is a reland of commit 8d652f1 Original change's description: > Remove TODOs in GNI exporter tool > > Client CLs: > - https://crrev.com/c/6031190 > - flutter/engine#56627 > > PDFium used to use skcms_sources, but that was updated in > https://pdfium-review.googlesource.com/c/pdfium/+/113670 > > Change-Id: I2b464d2bf5cd6cbba6f13bf72981e33da0e848bd > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/920816 > Reviewed-by: Eric Boren <[email protected]> Change-Id: I3d866c16f628838661ec400eec41f09b27b5fd35 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/921634 Reviewed-by: Eric Boren <[email protected]>
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
In https://skia-review.googlesource.com/c/skia/+/884096, Skia broke up this gni file list into Ganesh and Graphite specific code. Since Flutter only needs Ganesh sources, this can be made more precise. ## Pre-launch Checklist - [ x ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ x ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ x ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ x ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ x ] I updated/added relevant documentation (doc comments with `///`). - [ x ] I signed the [CLA]. - [ x ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://skia-review.googlesource.com/c/skia/+/884096, Skia broke up this gni file list into Ganesh and Graphite specific code. Since Flutter only needs Ganesh sources, this can be made more precise.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.