Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jason-simmons
Copy link
Member

No description provided.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-simmons jason-simmons added autosubmit Merge PR when tree becomes green via auto submit App warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. labels Nov 12, 2024
@auto-submit auto-submit bot merged commit 289a3fb into flutter:main Nov 12, 2024
33 of 34 checks passed
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 12, 2024
@jason-simmons
Copy link
Member Author

jason-simmons commented Nov 12, 2024

This should fix the BackdropCountDown test errors seen in flutter/flutter#158521

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 12, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 13, 2024
…158541)

flutter/engine@877abb9...08348c9

2024-11-12 [email protected] [Linux] Configure depth and stencil framebuffer attachments needed for Impeller (flutter/engine#56516)
2024-11-12 [email protected] macOS: ARC bridge casts for FlutterMetalTexture.user_data (flutter/engine#56518)
2024-11-12 [email protected] [Impeller] prevent no-op backend from throwing exceptions during image  decoding (flutter/engine#56522)
2024-11-12 [email protected] Roll Dart SDK from 69170fac244c to 5f42ef8f15d5 (4 revisions) (flutter/engine#56539)
2024-11-12 [email protected] Roll Fuchsia Linux SDK from BajfrJuYeyWvnBhuM... to z-cm2nR0aJ4lXfwZ0... (flutter/engine#56538)
2024-11-12 [email protected] Roll Skia from aa099ff91e2f to 7d5c206fc873 (6 revisions) (flutter/engine#56541)
2024-11-12 [email protected] [Impeller] In canvas_unittests, only create an MSAA offscreen texture if the platform supports MSAA (flutter/engine#56542)
2024-11-12 [email protected] [iOS] Fix slider semantics node answer to accessibility activate (flutter/engine#56427)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from BajfrJuYeyWv to z-cm2nR0aJ4l

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

e: impeller warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants