This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add FlutterTaskRunnerDescription.destruction_callback #56445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is a "what do you think about this approach?" patch. There are other ways we could do this but it has the nice property that we have similar Task runner destruction happens during the |
cbracken
commented
Nov 8, 2024
stuartmorgan-g
approved these changes
Nov 8, 2024
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with the comment suggestion (and a preference for the bridge-based retain count management, but LGTM either way).
Adds a `destruction_callback` member to `FlutterTaskRunnerDescription` that provides embedder developers a means of performing any cleanup of resources tied to the lifetime of the task runner. In the case of the macOS embedder, the task runner holds a reference to the engine itself that is used in the `post_task_callback` and whose lifetime needs to exceed that of the task runner. This refactoring allows us to centralise all related retain count manipulation around task runner setup. This is a refactor of the lifecycle bits of #13300.
cbracken
added
the
autosubmit
Member
Author
|
Talked to @chinmaygarde as well and got a verbal lgtm. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 8, 2024
…158398) flutter/engine@1b567e8...6b77347 2024-11-08 [email protected] Add FlutterTaskRunnerDescription.destruction_callback (flutter/engine#56445) 2024-11-08 [email protected] Roll Skia from d0ee80612f86 to 778b21720a61 (5 revisions) (flutter/engine#56457) 2024-11-08 [email protected] Manual roll Dart SDK from 50c620224f27 to cfa1826c3df1 (2 revisions) (flutter/engine#56456) 2024-11-08 [email protected] [Impeller] Switch to uniform arrays for gradient data on non-SSBO hardware (flutter/engine#56441) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…#56445) Adds a `destruction_callback` member to `FlutterTaskRunnerDescription` that provides embedder developers a means of performing any cleanup of resources tied to the lifetime of the task runner. In the case of the macOS embedder, the task runner holds a reference to the engine itself that is used in the `post_task_callback` and whose lifetime needs to match/exceed that of the task runner. This refactoring allows us to centralise all related retain count manipulation around task runner setup. This is a refactor of the lifecycle bits of flutter/engine#13300. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
destruction_callbackmember toFlutterTaskRunnerDescriptionthat provides embedder developers a means of performing any cleanup of resources tied to the lifetime of the task runner.In the case of the macOS embedder, the task runner holds a reference to the engine itself that is used in the
post_task_callbackand whose lifetime needs to match/exceed that of the task runner. This refactoring allows us to centralise all related retain count manipulation around task runner setup.This is a refactor of the lifecycle bits of #13300.
Issue: flutter/flutter#137801
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.