In the embedder Impeller render target, use a multisample texture for the depth buffer only if MSAA is supported #56444
Conversation
… the depth buffer only if MSAA is supported Fixes flutter/flutter#158000
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
Thank you Jason!
jason-simmons
added
the
autosubmit
…exture for the depth buffer only if MSAA is supported (flutter/engine#56444)
…exture for the depth buffer only if MSAA is supported (flutter/engine#56444)
…158393) flutter/engine@a08bd5a...1b567e8 2024-11-08 [email protected] In the embedder Impeller render target, use a multisample texture for the depth buffer only if MSAA is supported (flutter/engine#56444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
… the depth buffer only if MSAA is supported (flutter/engine#56444) Fixes flutter#158000
2 participants
Fixes flutter/flutter#158000