This repository was archived by the owner on Feb 25, 2025. It is now read-only.
iOS,macOS: Add Obj-C cflags to all Obj-C targets #56386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-ios
affects: desktop
platform-macos
e: impeller
labels
cbracken
commented
Nov 5, 2024
| ] | ||
|
|
||
| if (is_mac) { | ||
| if (is_mac || is_ios) { |
Member
Author
There was a problem hiding this comment.
Note: making consistent with the associated conditional in the target above that this one is testing.
cbracken
commented
Nov 5, 2024
| void* texture) { | ||
| GrMtlTextureInfo info; | ||
| info.fTexture.reset([(id<MTLTexture>)texture retain]); | ||
| info.fTexture.retain(texture); |
Member
Author
There was a problem hiding this comment.
Found the non-arc code! Doesn't need a bridge cast since this is already void*.
cbracken
commented
Nov 5, 2024
|
|
||
| if (impeller_enable_metal) { | ||
| deps += [ "//flutter/impeller/renderer/backend/metal:metal_unittests" ] | ||
| } |
Member
Author
There was a problem hiding this comment.
No need to build these guys on windows, linux, or custom embedders for platforms without metal enabled.
hellohuanlin
approved these changes
Nov 5, 2024
cbracken
added
the
autosubmit
jmagman
approved these changes
Nov 5, 2024
| "core:allocator_unittests", | ||
| "display_list:skia_conversions_unittests", | ||
| "geometry:geometry_unittests", | ||
| "renderer/backend/metal:metal_unittests", |
Member
There was a problem hiding this comment.
How was this passing if impeller_enable_metal was false?
Contributor
|
auto label is removed for flutter/engine/56386, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
Ensure that all Objective-C code in the codebase are being built with the standard set of Flutter Objective-C compiler flags with ARC enabled. Also bumps the cflags config up to the top of the first block within each target in which Objective-C sources appear, so that the location is consistent. Issue: flutter/flutter#137801
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 6, 2024
…158295) flutter/engine@58ac1da...b36ca33 2024-11-06 [email protected] [skwasm] Fix empty backdrop drawing. (flutter/engine#56385) 2024-11-06 [email protected] [Impeller] generate stroke vertices into point arena. (flutter/engine#56390) 2024-11-06 [email protected] [Impeller] Do not capture the temporary ImpellerMapping struct pointer when storing release callbacks in libImpeller (flutter/engine#56411) 2024-11-06 6844906[email protected] Roll ICU from 9408c6fd4a39 to 4239b1559d11 (2 revisions) (flutter/engine#56407) 2024-11-06 [email protected] iOS,macOS: Add Obj-C cflags to all Obj-C targets (flutter/engine#56386) 2024-11-06 [email protected] Roll Skia from afaed8923682 to cf33c4e96e81 (5 revisions) (flutter/engine#56408) 2024-11-06 [email protected] Manual roll Dart SDK from 1c1d0420539f to d456f613465a (6 revisions) (flutter/engine#56406) 2024-11-06 [email protected] [Impeller] Avoid errors due to triangle fans usage on Molten. (flutter/engine#56321) 2024-11-06 [email protected] Roll Skia from b4df8dda7ffc to afaed8923682 (14 revisions) (flutter/engine#56404) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Ensure that all Objective-C code in the codebase is being built with the standard set of Flutter Objective-C compiler flags with ARC enabled. Also bumps the cflags config up to the top of the first block within each target in which Objective-C sources appear, so that the location is consistent. Migrates The following targets to ARC, which had been missed in previous passes since they didn't declare the standard Flutter Obj-C[++] cflags: * `//flutter/fml:fml_unittests` * `//flutter/impeller/golden_tests:metal_screenshot` * `//flutter/impeller/playground:playground` * `//flutter/impeller/backend/metal:metal` * `//flutter/impeller/backend/metal:metal_unittests` * `//shell/gpu:gpu_surface_metal_unittests` * `//flutter/shell/platform/embedder:embedder_unittests` This patch includes no semantic changes. Issue: flutter#137801 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all Objective-C code in the codebase is being built with the standard set of Flutter Objective-C compiler flags with ARC enabled.
Also bumps the cflags config up to the top of the first block within each target in which Objective-C sources appear, so that the location is consistent.
Migrates The following targets to ARC, which had been missed in previous passes since they didn't declare the standard Flutter Obj-C[++] cflags:
//flutter/fml:fml_unittests//flutter/impeller/golden_tests:metal_screenshot//flutter/impeller/playground:playground//flutter/impeller/backend/metal:metal//flutter/impeller/backend/metal:metal_unittests//shell/gpu:gpu_surface_metal_unittests//flutter/shell/platform/embedder:embedder_unittestsThis patch includes no semantic changes.
Issue: flutter/flutter#137801
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.