This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add and document and explicit toARGB32.
#56329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Nov 1, 2024
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
lgtm, nit about adding test that uses deprecated member.
testing/dart/color_test.dart
Outdated
|
|
||
| test('value and toARGB32 are equivalent methods', () { | ||
| const Color halfRed = Color.from(alpha: 1.0, red: 0.5, green: 0, blue: 0); | ||
| expect(halfRed.value, halfRed.toARGB32()); |
Member
There was a problem hiding this comment.
It's probably better not to introduce a new test that uses a deprecated property. I'd just assert it is a specific integer.
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/56329, due to - The status or check suite Linux linux_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
Got my local test runner working again, and I'll have this fixed and merged shortly. |
matanlurey
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/56329, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 6, 2024
Unblocks landing flutter/engine#56329. @jtmcdole monorepo can't come soon enough...
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2024
jason-simmons
added a commit
to jason-simmons/flutter_tests
that referenced
this pull request
Nov 6, 2024
…updated for Color.toARGB32 flutter/engine#56329 added a Color.toARGB32 method. This test is using a package that subclasses Color, and that package needs to be updated to build with the latest engine.
auto-submit bot
pushed a commit
to flutter/tests
that referenced
this pull request
Nov 6, 2024
…updated for Color.toARGB32 (#421) flutter/engine#56329 added a Color.toARGB32 method. This test is using a package that subclasses Color, and that package needs to be updated to build with the latest engine.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 6, 2024
…158283) flutter/engine@f03f113...58ac1da 2024-11-06 [email protected] [Impeller] split downsample shader into GLES variant. (flutter/engine#56376) 2024-11-06 [email protected] Roll Skia from 82175b411c80 to b4df8dda7ffc (1 revision) (flutter/engine#56398) 2024-11-06 [email protected] Add and document and explicit `toARGB32`. (flutter/engine#56329) 2024-11-06 [email protected] Roll Fuchsia Test Scripts from _fkA2GjLQH4bc_n2p... to 6FgM4KTbxxmyYoiOs... (flutter/engine#56392) 2024-11-05 [email protected] Manual roll Dart SDK from 3e840340c412 to 1c1d0420539f (2 revisions) (flutter/engine#56391) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#157128.