[Impeller] fix downsample with decal tile mode. #56316
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| uniform FragInfo { | ||
| float edge; | ||
| float ratio; | ||
| float decal; |
There was a problem hiding this comment.
| float decal; | |
| float use_decal; |
Since we have to use float types as bool values, it helps to reinforce this isn't a continuous value like it seems.
|
Will this potentially fix flutter/flutter#157959 too? That looks like a tiling mode issue with blurs. |
|
Uhh, I think so? its subtle and I can't really tell |
|
Yep, check out the metal reference image: https://flutter-engine-gold.skia.org/search?corpus=flutter-engine&include_ignored=false&left_filter=name%3Dimpeller_Play_AiksTest_MaskBlurTexture_Metal&max_rgba=0&min_rgba=0&negative=true¬_at_head=false&positive=true&reference_image_required=false&right_filter=&sort=descending&untriaged=true I'd close that issue out too as a result of this. |
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/56316, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jonahwilliams
added
the
autosubmit
…158034) flutter/engine@7dfdcac...38b6165 2024-11-01 [email protected] [Impeller] fix downsample with decal tile mode. (flutter/engine#56316) 2024-11-01 [email protected] Roll Skia from dfbb0e6bc974 to 89ac72bb4922 (6 revisions) (flutter/engine#56320) 2024-11-01 [email protected] Remove superfluous dart2wasm test suites/bundles. (flutter/engine#56315) 2024-11-01 [email protected] Write run_tests console logs to stdout instead of stderr (flutter/engine#56312) 2024-11-01 [email protected] [impeller] use greater equal rather than greater depth compare. (flutter/engine#56310) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes flutter#157956 Fixes flutter#157959 Decal tile mode needs to be emulated on platforms that don't support it.
2 participants
Fixes flutter/flutter#157956
Fixes flutter/flutter#157959
Decal tile mode needs to be emulated on platforms that don't support it.