This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[impeller] use greater equal rather than greater depth compare. #56310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
added 2 commits
November 1, 2024 11:22
jonahwilliams
changed the title
jonahwilliams
changed the title
jonahwilliams
changed the title
Contributor
Author
|
I think the new golden diffs look better but I'm not familiar with them. FYI @flar maybe? |
chinmaygarde
approved these changes
Nov 1, 2024
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
This fixes flutter/flutter#157885 as well. I left some notes on the differences I see your linked issue. I also don't see the golden diffs though.
Member
gaaclarke
approved these changes
Nov 1, 2024
Member
|
The eye still isn't quite right though. |
Contributor
Author
|
That looks correct to me? |
jonahwilliams
added
the
autosubmit
Member
|
I am just now realizing the smiley was wearing a cap 🧢 |
Member
|
I didn't see a cap, I saw it more like one of these situations: |
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Nov 1, 2024
Added the test case for flutter/flutter#157885 to the corpus but Jonah fixed it in flutter#56310. Fixes flutter/flutter#158024 which is more of an inconvenience on macOS.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 2, 2024
…158034) flutter/engine@7dfdcac...38b6165 2024-11-01 [email protected] [Impeller] fix downsample with decal tile mode. (flutter/engine#56316) 2024-11-01 [email protected] Roll Skia from dfbb0e6bc974 to 89ac72bb4922 (6 revisions) (flutter/engine#56320) 2024-11-01 [email protected] Remove superfluous dart2wasm test suites/bundles. (flutter/engine#56315) 2024-11-01 [email protected] Write run_tests console logs to stdout instead of stderr (flutter/engine#56312) 2024-11-01 [email protected] [impeller] use greater equal rather than greater depth compare. (flutter/engine#56310) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Nov 4, 2024
Added the test case for flutter/flutter#157885 to the corpus but Jonah fixed it in flutter#56310. Fixes flutter/flutter#158024 which is more of an inconvenience on macOS.
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
Added the test case for flutter/flutter#157885 to the corpus but Jonah fixed it in #56310. Fixes flutter/flutter#158024 which is more of an inconvenience on macOS.
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…ter/engine#56310) Marking ready for review for golden testing Fixes flutter#153504 Fixes some other ones too? It seems like metal and vulkan are already behaving like they are using greater equal depth compare. GL behaves correctly like greater compare, but that leads to rendering bugs. Just switch it to greater equal
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…r/engine#56321) Added the test case for flutter#157885 to the corpus but Jonah fixed it in flutter/engine#56310. Fixes flutter#158024 which is more of an inconvenience on macOS.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking ready for review for golden testing
Fixes flutter/flutter#153504
Fixes some other ones too?
It seems like metal and vulkan are already behaving like they are using greater equal depth compare. GL behaves correctly like greater compare, but that leads to rendering bugs. Just switch it to greater equal