This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Allow BufferViews to have non-owning references to DeviceBuffers (#56224)" #56285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Oct 31, 2024
auto-submit
bot
deleted the
revert_0b5aed13288c16a2a9ab049a55aaebb64a6caeac
branch
gaaclarke
added a commit
to gaaclarke/engine
that referenced
this pull request
Oct 31, 2024
…eviceBuffers (flutter#56224)" (flutter#56285)" This reverts commit cdabd2d.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 1, 2024
…157972) flutter/engine@bb77cf8...cd46383 2024-10-31 [email protected] reland: Allow BufferViews to have non-owning references to DeviceBuffers (flutter/engine#56286) 2024-10-31 [email protected] Roll Skia from 9168ad248c69 to a5e3b3556739 (1 revision) (flutter/engine#56283) 2024-10-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Allow BufferViews to have non-owning references to DeviceBuffers (#56224)" (flutter/engine#56285) 2024-10-31 [email protected] macOS: migrate third_party/accessibility to ARC (flutter/engine#56281) 2024-10-31 [email protected] Allow BufferViews to have non-owning references to DeviceBuffers (flutter/engine#56224) 2024-10-31 [email protected] [Impeller] Do not use fast mask blur for stroked shapes (flutter/engine#56247) 2024-10-31 [email protected] [Impeller] make desktop GL render. (flutter/engine#56274) 2024-10-31 [email protected] Vastly rewrite and expand `et/README.md` (flutter/engine#56250) 2024-10-31 [email protected] Roll Fuchsia Linux SDK from dDWvmfG4AxSEs0BQA... to MjcuejuzYvYGobbFM... (flutter/engine#56280) 2024-10-31 [email protected] Roll Dart SDK from f3e3dc44b1dc to bd93105c4fb6 (2 revisions) (flutter/engine#56278) 2024-10-31 [email protected] Embedder: migrate Metal surfaces to ARC (flutter/engine#56279) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from dDWvmfG4AxSE to MjcuejuzYvYG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…fers (flutter#56224)" (flutter/engine#56285) Reverts: flutter/engine#56224 Initiated by: jonahwilliams Reason for reverting: merge issue. Original PR Author: gaaclarke Reviewed By: {jonahwilliams} This change reverts the following previous change: issue: flutter#157538 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #56224
Initiated by: jonahwilliams
Reason for reverting: merge issue.
Original PR Author: gaaclarke
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
issue: flutter/flutter#157538
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.