This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland single threaded Skwasm #56282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit bot
pushed a commit
to flutter/buildroot
that referenced
this pull request
Nov 1, 2024
#917) (#918) This relands the emscripten config changes that had to be reverted previously. This is to support the new version of emscripten introduced in this engine PR: flutter/engine#56282
eyebrowsoffire
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/56282, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label. |
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 1, 2024
…158021) flutter/engine@7b176f4...7dfdcac 2024-11-01 [email protected] Reland single threaded Skwasm (flutter/engine#56282) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
This attempts to reland the single-threaded Skwasm PR: flutter/engine#56206 The main changes here are in the second commit: * We need to actually bundle the `skwasm_st` artifacts in `flutter_web_sdk.zip` * The `locateFile` hack no longer works since emscripten doesn't actually create a worker.js file anymore. So instead, that has been modified to use the `mainScriptUrlOrBlob` module API to do a very similar hack. Note: I did presubmit testing with the framework CI and it appears the pertinent tests pass. See flutter#157967
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to reland the single-threaded Skwasm PR: #56206
The main changes here are in the second commit:
skwasm_startifacts influtter_web_sdk.ziplocateFilehack no longer works since emscripten doesn't actually create a worker.js file anymore. So instead, that has been modified to use themainScriptUrlOrBlobmodule API to do a very similar hack.Note: I did presubmit testing with the framework CI and it appears the pertinent tests pass. See flutter/flutter#157967