This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
libtxt: apply an offset to drawing operations instead of translating the canvas #5628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
chinmaygarde
approved these changes
Jun 27, 2018
cbracken
approved these changes
Jun 27, 2018
Member
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Contributor
|
Thanks! |
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Jul 10, 2018
* ensure a11y state is communicated back to flutter (flutter/engine#5631) * Roll src/third_party/skia b1b87d9df81e..a1e5630183c1 (10 commits) (flutter/engine#5637) * Roll src/third_party/skia 385804514edf..b1b87d9df81e (6 commits) (flutter/engine#5636) * Roll src/third_party/skia e97bb26893a1..385804514edf (1 commits) (flutter/engine#5635) * Roll src/third_party/skia e2e52e46ca63..e97bb26893a1 (1 commits) (flutter/engine#5634) * Roll src/third_party/skia 14de25dfc7c4..e2e52e46ca63 (2 commits) (flutter/engine#5633) * Roll src/third_party/skia 551dc3e91143..14de25dfc7c4 (2 commits) (flutter/engine#5630) * libtxt: apply an offset to drawing operations instead of translating the canvas (flutter/engine#5628) * Roll src/third_party/skia 059a9ab4bcd0..551dc3e91143 (5 commits) (flutter/engine#5629) * Roll src/third_party/skia 45c9dab4c3ec..059a9ab4bcd0 (8 commits) (flutter/engine#5627) * Remove some unused code from the Android host (flutter/engine#5619) * Roll src/third_party/skia 37b7e4714558..45c9dab4c3ec (1 commits) (flutter/engine#5626) * Roll src/third_party/skia c421ca1d6e41..37b7e4714558 (2 commits) (flutter/engine#5624) * Roll src/third_party/skia 5b201e3b0ba8..c421ca1d6e41 (3 commits) (flutter/engine#5623) * Roll src/third_party/skia d47fe095cf88..5b201e3b0ba8 (6 commits) (flutter/engine#5622) * Roll src/third_party/skia 9c0ce41cf711..d47fe095cf88 (12 commits) (flutter/engine#5618 * Roll src/third_party/skia d4b2adeaa929..9c0ce41cf711 (7 commits) (flutter/engine#5617) * Roll src/third_party/skia f46710802ad5..d4b2adeaa929 (1 commits) (flutter/engine#5616) Also update goldens to 2694735bcfe755238f42da1be9a472e6795c9bdd * Update goldens for flutter#19044 (flutter/goldens#6)
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Jul 10, 2018
* ensure a11y state is communicated back to flutter (flutter/engine#5631) * Roll src/third_party/skia b1b87d9df81e..a1e5630183c1 (10 commits) (flutter/engine#5637) * Roll src/third_party/skia 385804514edf..b1b87d9df81e (6 commits) (flutter/engine#5636) * Roll src/third_party/skia e97bb26893a1..385804514edf (1 commits) (flutter/engine#5635) * Roll src/third_party/skia e2e52e46ca63..e97bb26893a1 (1 commits) (flutter/engine#5634) * Roll src/third_party/skia 14de25dfc7c4..e2e52e46ca63 (2 commits) (flutter/engine#5633) * Roll src/third_party/skia 551dc3e91143..14de25dfc7c4 (2 commits) (flutter/engine#5630) * libtxt: apply an offset to drawing operations instead of translating the canvas (flutter/engine#5628) * Roll src/third_party/skia 059a9ab4bcd0..551dc3e91143 (5 commits) (flutter/engine#5629) * Roll src/third_party/skia 45c9dab4c3ec..059a9ab4bcd0 (8 commits) (flutter/engine#5627) * Remove some unused code from the Android host (flutter/engine#5619) * Roll src/third_party/skia 37b7e4714558..45c9dab4c3ec (1 commits) (flutter/engine#5626) * Roll src/third_party/skia c421ca1d6e41..37b7e4714558 (2 commits) (flutter/engine#5624) * Roll src/third_party/skia 5b201e3b0ba8..c421ca1d6e41 (3 commits) (flutter/engine#5623) * Roll src/third_party/skia d47fe095cf88..5b201e3b0ba8 (6 commits) (flutter/engine#5622) * Roll src/third_party/skia 9c0ce41cf711..d47fe095cf88 (12 commits) (flutter/engine#5618 * Roll src/third_party/skia d4b2adeaa929..9c0ce41cf711 (7 commits) (flutter/engine#5617) * Roll src/third_party/skia f46710802ad5..d4b2adeaa929 (1 commits) (flutter/engine#5616)
bkonyi
pushed a commit
that referenced
this pull request
Jul 11, 2018
bkonyi
pushed a commit
that referenced
this pull request
Jul 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#18710