[Impeller] make desktop GL render. #56274
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
jason-simmons
left a comment
jason-simmons
left a comment
There was a problem hiding this comment.
Add a capability check for desktop GL platforms that require VAOs
| return false; | ||
| } | ||
|
|
||
| if (!gl.GetCapabilities()->IsES()) { |
There was a problem hiding this comment.
I think any non-ES GL will need VAOs? FYI @chinmaygarde
There was a problem hiding this comment.
I'd put this behind a cap check. Because vertex arrays are available on desktop GL, but also ES 3.0 and above or ES 2.0 with the GL_OES_vertex_array_object extension. This extension is almost always available. This is a fine start for now though. But file a followup?
There was a problem hiding this comment.
This may be because you just wanted to make things work on desktop GL. So feel free to ignore if we are going to patch this in later.
But, VAOs are an optimization that actually become a pessimization as used here.
VAOs encode the state that is configured by the EnableVertexAttribArray/VertexAttribPointer goop later into a single object that can be bound. So, you only need to configure the arrays once (ideally during "pipeline" construction), save the VAO, and bind it before the draw call while skipping the rest of the API traffic.
Creating the new VAO per call is just extra ceremony that is unnecessary.
I'd create a separate object with its own entry in the reactor handles table that is configured when the pipeline is created and a bind call that either binds the VAO if one is available or dumps additional traffic if not.
But, we can do this all later. This still LGTM and will work to unblock desktop GL.
There was a problem hiding this comment.
Yeah the goal is very much "make it render" for now. I don't know if we'll get to the point where we work on GL performance. I'd like to think we can push folks to switch to Vulkan where feasible. But if that doesn't happen then we'd have some work to do to write a more 3.0-style renderer.
jonahwilliams
added
the
autosubmit
…157972) flutter/engine@bb77cf8...cd46383 2024-10-31 [email protected] reland: Allow BufferViews to have non-owning references to DeviceBuffers (flutter/engine#56286) 2024-10-31 [email protected] Roll Skia from 9168ad248c69 to a5e3b3556739 (1 revision) (flutter/engine#56283) 2024-10-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Allow BufferViews to have non-owning references to DeviceBuffers (#56224)" (flutter/engine#56285) 2024-10-31 [email protected] macOS: migrate third_party/accessibility to ARC (flutter/engine#56281) 2024-10-31 [email protected] Allow BufferViews to have non-owning references to DeviceBuffers (flutter/engine#56224) 2024-10-31 [email protected] [Impeller] Do not use fast mask blur for stroked shapes (flutter/engine#56247) 2024-10-31 [email protected] [Impeller] make desktop GL render. (flutter/engine#56274) 2024-10-31 [email protected] Vastly rewrite and expand `et/README.md` (flutter/engine#56250) 2024-10-31 [email protected] Roll Fuchsia Linux SDK from dDWvmfG4AxSEs0BQA... to MjcuejuzYvYGobbFM... (flutter/engine#56280) 2024-10-31 [email protected] Roll Dart SDK from f3e3dc44b1dc to bd93105c4fb6 (2 revisions) (flutter/engine#56278) 2024-10-31 [email protected] Embedder: migrate Metal surfaces to ARC (flutter/engine#56279) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from dDWvmfG4AxSE to MjcuejuzYvYG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes flutter#143387 Will be tested in flutter#157888
3 participants
Fixes flutter/flutter#143387
Will be tested in flutter/flutter#157888