Vastly rewrite and expand et/README.md
#56250
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| At the time of this writing, the linters always operate on the entire | ||
| repository. | ||
|
|
||
| ### Running a Flutter app with a local engine build |
There was a problem hiding this comment.
TODO: Add this before I merge.
jtmcdole
left a comment
jtmcdole
left a comment
There was a problem hiding this comment.
LGTM.
Small ask: a caution about building multiple engines and consuming a lot of space. The easier we make it for folks to build, the quicker they'll lose their free space.
| Run "et help <command>" for more information about a command. | ||
| ``` | ||
| ## Understanding the concept of a build configuration |
There was a problem hiding this comment.
It could be useful to link to the docs for build configurations from the section somewhere: https://github.com/flutter/engine/blob/main/ci/builders/README.md
There was a problem hiding this comment.
Done, added as a TIP below.
tools/engine_tool/README.md
Outdated
| The default and most common operation is to build a _host_ variant of the | ||
| engine, or an engine that runs on the local (desktop) operating system currently | ||
| being used. For example, when running on an ARM64 MacOS laptop, an ARM64 MacOS |
Done! |
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
Thanks for improving these docs!
matanlurey
added
the
autosubmit
…157972) flutter/engine@bb77cf8...cd46383 2024-10-31 [email protected] reland: Allow BufferViews to have non-owning references to DeviceBuffers (flutter/engine#56286) 2024-10-31 [email protected] Roll Skia from 9168ad248c69 to a5e3b3556739 (1 revision) (flutter/engine#56283) 2024-10-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Allow BufferViews to have non-owning references to DeviceBuffers (#56224)" (flutter/engine#56285) 2024-10-31 [email protected] macOS: migrate third_party/accessibility to ARC (flutter/engine#56281) 2024-10-31 [email protected] Allow BufferViews to have non-owning references to DeviceBuffers (flutter/engine#56224) 2024-10-31 [email protected] [Impeller] Do not use fast mask blur for stroked shapes (flutter/engine#56247) 2024-10-31 [email protected] [Impeller] make desktop GL render. (flutter/engine#56274) 2024-10-31 [email protected] Vastly rewrite and expand `et/README.md` (flutter/engine#56250) 2024-10-31 [email protected] Roll Fuchsia Linux SDK from dDWvmfG4AxSEs0BQA... to MjcuejuzYvYGobbFM... (flutter/engine#56280) 2024-10-31 [email protected] Roll Dart SDK from f3e3dc44b1dc to bd93105c4fb6 (2 revisions) (flutter/engine#56278) 2024-10-31 [email protected] Embedder: migrate Metal surfaces to ARC (flutter/engine#56279) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from dDWvmfG4AxSE to MjcuejuzYvYG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closes flutter#157876. /cc @dcharkes @jensjoha as well (documented `--gn-args`)
3 participants
Closes flutter/flutter#157876.
/cc @dcharkes @jensjoha as well (documented
--gn-args)