Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@aam
Copy link
Member

@aam aam commented Oct 29, 2024

'--time'-runs were done to investigate flutter/flutter#154437, which was fixed.

'--time'-runs were done to investigate flutter/flutter#154437, which was fixed.
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 29, 2024
@auto-submit auto-submit bot merged commit d0ad7cf into flutter:main Oct 29, 2024
26 checks passed
@aam aam deleted the remove-timed-gen-snapshot branch October 29, 2024 17:28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 29, 2024
…157820)

flutter/engine@725c8e4...795b549

2024-10-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] disable AHBs on devices that were upgraded to 29. (#56202)" (flutter/engine#56212)
2024-10-29 [email protected] Remove --time run of gen_snapshot. (flutter/engine#56204)
2024-10-29 [email protected] [Impeller] Clip the DrawImageRect source rect to the bounds of the image (flutter/engine#56183)
2024-10-29 [email protected] [Impeller] disable Maleoon GPU from using Vulkan. (flutter/engine#56203)
2024-10-29 [email protected] [Impeller] disable AHBs on devices that were upgraded to 29. (flutter/engine#56202)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
'--time'-runs were done to investigate flutter#154437, which was fixed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants