This repository was archived by the owner on Feb 25, 2025. It is now read-only.
iOS: migrate Metal testing types to ARC #56156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
cbracken
commented
Oct 27, 2024
Contributor
|
test-exempt: code refactor with no semantic change |
stuartmorgan-g
approved these changes
Oct 31, 2024
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with either the ivar or the TODOs.
This migrates Flutter's TestMetalContext and TestMetalSurface to ARC. Also migrates to using sk_cfp::retain (which retains the passed in pointer) rather than sk_cfp::reset, which only releases the previous pointer but doesn't retain the incoming pointer. No changes to tests since no semantic changes. Issue: flutter/flutter#137801
cbracken
added
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 31, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 31, 2024
…157960) flutter/engine@f2154ef...bb77cf8 2024-10-31 [email protected] iOS: migrate Metal testing types to ARC (flutter/engine#56156) 2024-10-31 [email protected] iOS,macOS: migrate shell/gpu to ARC (flutter/engine#56157) 2024-10-31 [email protected] Roll Skia from 3c628426f85f to 9168ad248c69 (3 revisions) (flutter/engine#56272) 2024-10-31 [email protected] [Impeller] Reland: disable AHBs on devices that were upgraded to 29. (flutter/engine#56221) 2024-10-31 [email protected] Add `timeout` to `local_engine`. (flutter/engine#56271) 2024-10-31 [email protected] Refactor `ArgParser.usage` tests for `BuildPlan` to reduce duplication. (flutter/engine#56254) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
This migrates Flutter's TestMetalContext and TestMetalSurface to ARC. Also migrates to using `sk_cfp::retain` (which retains the passed in pointer) rather than `sk_cfp::reset`, which only releases the previous pointer but doesn't retain the incoming pointer. No changes to tests since no semantic changes. Issue: flutter#137801 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates Flutter's TestMetalContext and TestMetalSurface to ARC.
Also migrates to using
sk_cfp::retain(which retains the passed in pointer) rather thansk_cfp::reset, which only releases the previous pointer but doesn't retain the incoming pointer.No changes to tests since no semantic changes.
Issue: flutter/flutter#137801
Issue: flutter/flutter#158998
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.