This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland (x2) Skwasm overlay optimizations #56067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryterkelsen
approved these changes
Oct 24, 2024
Contributor
harryterkelsen
left a comment
harryterkelsen
left a comment
There was a problem hiding this comment.
LGTM with nits. Also I suggest adding a regression test for the case that caused the original PR to be reverted
|
|
||
| LayerSlice buildWithOperation(LayerOperation operation) { | ||
| final ui.Rect recorderRect = operation.mapRect(cullRect ?? ui.Rect.zero); | ||
| final (recorder, canvas) = debugRecorderFactory != null ? debugRecorderFactory!(recorderRect) : defaultRecorderFactory(recorderRect); |
Contributor
There was a problem hiding this comment.
nit: maybe worth pulling the logic to create a recorder (using either the debug factory or the default factory) into its own method
| internalBootstrapBrowserTest(() => testMain); | ||
| } | ||
|
|
||
| void testMain() { |
Contributor
There was a problem hiding this comment.
add a regression test for the bug which caused you to have to revert the original PR?
| sliceIndex = 0; | ||
| final SceneSlice slice = sceneSlices[sliceIndex]; | ||
| slice.platformViewOcclusionMap.addRect(globalPlatformViewRect); | ||
| print('placed platform view. localRect: $rect globalRect: $globalPlatformViewRect sliceIndex: $sliceIndex'); |
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 26, 2024
…157662) flutter/engine@7c5c5fe...c9b8ac9 2024-10-26 [email protected] Roll Skia from da6c17329e0b to cadf2538dcde (3 revisions) (flutter/engine#56147) 2024-10-25 [email protected] Removed clamping from dithering (flutter/engine#56140) 2024-10-25 [email protected] Reland (x2) Skwasm overlay optimizations (flutter/engine#56067) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
This is an attempt to reland flutter/engine#55468 We now defer actually drawing the pictures until the build of the layer slices, so that we can calculate an accurate `cullRect` for the picture recorder This also contains a further optimization for the "simple" rendering case (no platform views) where we don't actually do any unnecessary occlusion calculations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to reland #55468
We now defer actually drawing the pictures until the build of the layer slices, so that we can calculate an accurate
cullRectfor the picture recorderThis also contains a further optimization for the "simple" rendering case (no platform views) where we don't actually do any unnecessary occlusion calculations.