Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 22, 2024

Cherry-pick the beta branch privacy location fix #55938 back to master so this doesn't regress in the next beta.

This is for flutter/flutter#157016 on master. Can be merged once the framework test flutter/flutter#157318 merges.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Oct 22, 2024

flutter/flutter#157318 has merged.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 22, 2024
@auto-submit auto-submit bot merged commit 2fad597 into flutter:main Oct 22, 2024
@jmagman jmagman deleted the macos-privacy branch October 22, 2024 20:46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 22, 2024
jonahwilliams pushed a commit to flutter/flutter that referenced this pull request Oct 23, 2024
…157389)

flutter/engine@2d3f0f4...50f6d98

2024-10-22 [email protected] [Impeller] refactor clip rendering.
(flutter/engine#56030)
2024-10-22 [email protected] Fix macos xcprivacy manifest copy location
(flutter/engine#56010)
2024-10-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Copy gen_snapshots using python's shutil.copy, avoid links (#55830)"
(flutter/engine#56034)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jmagman jmagman added the cp: stable cherry pick to the stable release candidate branch label Oct 23, 2024
@flutteractionsbot
Copy link

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

M97Chahboun pushed a commit to M97Chahboun/flutter that referenced this pull request Oct 30, 2024
…lutter#157389)

flutter/engine@2d3f0f4...50f6d98

2024-10-22 [email protected] [Impeller] refactor clip rendering.
(flutter/engine#56030)
2024-10-22 [email protected] Fix macos xcprivacy manifest copy location
(flutter/engine#56010)
2024-10-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Copy gen_snapshots using python's shutil.copy, avoid links (flutter#55830)"
(flutter/engine#56034)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
Cherry-pick the beta branch privacy location fix flutter/engine#55938 back to master so this doesn't regress in the next beta.

This is for flutter#157016 on master.  Can be merged once the framework test flutter#157318 merges.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects: desktop autosubmit Merge PR when tree becomes green via auto submit App cp: stable cherry pick to the stable release candidate branch platform-macos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants