This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Beta fix macos xcprivacy manifest copy location #55938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherfujino
changed the base branch from
main
to
flutter-3.27-candidate.0
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
Contributor
Author
|
I think someone will need to format my gn file, but I'm leaving the office now. |
jmagman
approved these changes
Oct 17, 2024
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
LGTM this matches
engine/shell/platform/darwin/macos/BUILD.gn
Line 242 in bf0b4f8
This was referenced Oct 17, 2024
Member
|
This framework test needs to land first flutter/flutter#157136 |
Member
Done. |
Member
|
I built the framework on this PR and the directory structure (and symlinks) looks right:
|
This was referenced Oct 18, 2024
christopherfujino
added
the
autosubmit
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 18, 2024
…on (#157136) The PrivacyInfo.xcprivacy file was originally copied to the top-level macOS framework, but instead needs to be in the Resources directory (which is a different path than iOS). This caused codesigning issues #157016. The path is being corrected flutter/engine#55938 so update the framework test to handle either path. It will be updated to just check the correct path once it rolls into the framework.
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
Cherry-pick the beta branch privacy location fix #55938 back to master so this doesn't regress in the next beta. This is for flutter/flutter#157016 on master. Can be merged once the framework test flutter/flutter#157318 merges. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
jmagman
added
cp: stable
christopherfujino
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Oct 23, 2024
…on (flutter#157136) The PrivacyInfo.xcprivacy file was originally copied to the top-level macOS framework, but instead needs to be in the Resources directory (which is a different path than iOS). This caused codesigning issues flutter#157016. The path is being corrected flutter/engine#55938 so update the framework test to handle either path. It will be updated to just check the correct path once it rolls into the framework.
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Cherry-pick the beta branch privacy location fix flutter/engine#55938 back to master so this doesn't regress in the next beta. This is for flutter#157016 on master. Can be merged once the framework test flutter#157318 merges. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were copying the macOS privacy manifest to the wrong path, which led to codesigning failing.
See flutter/flutter#157016 (comment) for more context.