This repository was archived by the owner on Feb 25, 2025. It is now read-only.
re-land "update the repo references for package:file (#55906)" #55935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
suggested changes
Oct 18, 2024
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
This should wait until the internal roll succeeds since we may need to roll back again.
Contributor
Author
Gotcha - I'll hold off on landing this for a bit. |
devoncarew
deleted the
revert-55916-revert_066a3c71187bb3b6ef694decb9c32287bcd06e45
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 21, 2024
…157290) flutter/engine@315540e...de569ba 2024-10-21 [email protected] re-land "update the repo references for package:file (#55906)" (flutter/engine#55935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…flutter/engine#55935) This is a re-land of the reverted PR, flutter/engine#55916 (it depended on a dart roll that was reverted, and has subsequently been re-landed). From the original PR: > The SoT repository for `package:file` has changed from google/file.dart to dart-lang/tools; this PR updates the DEPS file and the hard-coded paths in the two pubspec.yaml files (see dart-lang/tools#674).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-land of the reverted PR, #55916 (it depended on a dart roll that was reverted, and has subsequently been re-landed).
From the original PR: