This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] libImpeller: Publish SDK artifacts. #55783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
added
e: impeller
e: libimpeller
Member
Author
|
I can verify that the zip is being created. Not necessarily sure if the manifest updates to upload the artifacts are good though. |
zanderso
reviewed
Oct 9, 2024
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
Is there any need for a library from a release Android build?
Member
Author
|
No. Release/profile/debug are all the same. Just added the debug variants on all. |
zanderso
approved these changes
Oct 9, 2024
Member
Author
|
The presubs are sufficient to check the paths in the manifest right? I didn't know how to test those. |
chinmaygarde
added
the
autosubmit
Member
Yes. See step 26 on https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/2777090/overview. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 10, 2024
…156541) flutter/engine@590babc...3ce72a2 2024-10-10 [email protected] Roll Skia from 0a9bfc90496e to 1e269594df9d (1 revision) (flutter/engine#55801) 2024-10-10 [email protected] Roll Skia from 6e4a2f266a17 to 0a9bfc90496e (2 revisions) (flutter/engine#55799) 2024-10-10 [email protected] Roll Skia from 3a9e6b6a4721 to 6e4a2f266a17 (1 revision) (flutter/engine#55797) 2024-10-10 [email protected] Roll buildroot to pick up change to --time executions (flutter/engine#55792) 2024-10-10 [email protected] Roll Skia from 8c95b719bf05 to 3a9e6b6a4721 (1 revision) (flutter/engine#55793) 2024-10-09 [email protected] Move some `et` tests around and delete unused files. (flutter/engine#55764) 2024-10-09 [email protected] [web:a11y] make header a proper <header> (flutter/engine#55747) 2024-10-09 [email protected] Roll Skia from cf9a558b3abb to 8c95b719bf05 (1 revision) (flutter/engine#55788) 2024-10-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Run gen_snapshot under /usr/bin/time (#55777)" (#55787)" (flutter/engine#55789) 2024-10-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run gen_snapshot under /usr/bin/time (#55777)" (flutter/engine#55787) 2024-10-09 [email protected] Roll Skia from 1349ddc074ad to cf9a558b3abb (2 revisions) (flutter/engine#55785) 2024-10-09 [email protected] Run gen_snapshot under /usr/bin/time (flutter/engine#55777) 2024-10-09 [email protected] [Impeller] libImpeller: Publish SDK artifacts. (flutter/engine#55783) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#156358