Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matanlurey
Copy link
Contributor

Fixes flutter/flutter#156434.

A better fix for the workaround in flutter/flutter#156158.

This should likely be cherrypicked, as it's a memory leak, safe, and avoids workaround code in plugins.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2024
@auto-submit auto-submit bot merged commit e74c9cf into flutter:main Oct 9, 2024
@matanlurey matanlurey deleted the release-onTrimMemory-ImageReaderSurfaceProducer branch October 9, 2024 01:45
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 9, 2024
zanderso pushed a commit to flutter/flutter that referenced this pull request Oct 9, 2024
…156478)

flutter/engine@db0c0b7...4a97943

2024-10-09 [email protected] Roll Fuchsia Linux SDK from
TlU-It6X_ZLrNqMjW... to xGr5ZkxX3CajAY1xu... (flutter/engine#55770)
2024-10-09 [email protected] Roll Skia from a077e78e531f to
e0bb55353b27 (3 revisions) (flutter/engine#55768)
2024-10-09 [email protected] [Impeller] libImpeller: Allow
fetching OpenGL texture handle. (flutter/engine#55753)
2024-10-09 [email protected] Roll Fuchsia Test Scripts from
jCde9sMKJ3YAdG2DH... to _fkA2GjLQH4bc_n2p... (flutter/engine#55762)
2024-10-09 [email protected] Roll Skia from 701b6e4b4bc4 to
a077e78e531f (3 revisions) (flutter/engine#55761)
2024-10-09 [email protected]
Release`onTrimMemoryListener` after `ImageReaderSurfaceProducer`
released. (flutter/engine#55760)
2024-10-09 [email protected] [Flutter GPU] Get the GLES backend/Windows
working. (flutter/engine#55694)
2024-10-08 [email protected] [canvaskit]
Fix incorrect clipping with Opacity scene layer (flutter/engine#55751)
2024-10-08 [email protected] Refactor multi-file build
parsing into a single `BuildPlan` class. (flutter/engine#55720)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from TlU-It6X_ZLr to xGr5ZkxX3Caj

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…ased. (flutter/engine#55760)

Fixes flutter#156434.

A better fix for the workaround in flutter#156158.

This should likely be cherrypicked, as it's a memory leak, safe, and avoids workaround code in plugins.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SurfaceProducer.Callback should not fire once the surface is released

3 participants