[Impeller] libImpeller: Allow creating image color sources. #55754
Conversation
chinmaygarde
added
e: impeller
e: libimpeller
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
chinmaygarde
added
the
autosubmit
|
auto label is removed for flutter/engine/55754, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
bdero
left a comment
bdero
left a comment
There was a problem hiding this comment.
( *
)\ ) ( * ) ( `
(()/( )\ ) ` ) /( )\))(
/(_)|()/( ( )(_)|(_)()\
(_)) /(_))_(_(_())(_()((_)
| | (_)) __|_ _|| \/ |
| |__ | (_ | | | | |\/| |
|____| \___| |_| |_| |_|
chinmaygarde
force-pushed
the
imagecolorsource
branch
from
4538a5a to
2154752
Compare
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/55754, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
The mac failure seems to be a flake. But it is a darn persistent one. |
chinmaygarde
added
the
autosubmit
…156498) flutter/engine@3a95d6e...590babc 2024-10-09 [email protected] [Impeller] libImpeller: Allow creating image color sources. (flutter/engine#55754) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…engine#55754) Fixes flutter#156360 This was missed in the earlier bringup. cc @lyceel I did not expose the solid color source since (as @jonahwilliams [pointed out](flutter#156360 (comment))) all it does it [clear the current color source and set the color on the paint](https://github.com/flutter/engine/blob/a01daf5555569784a6e3ef4be856597eb73b9817/display_list/dl_builder.cc#L206).
3 participants
Fixes flutter/flutter#156360
This was missed in the earlier bringup.
cc @lyceel I did not expose the solid color source since (as @jonahwilliams pointed out) all it does it clear the current color source and set the color on the paint.