Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Member

cc @lyceel

@chinmaygarde chinmaygarde added e: impeller e: libimpeller The standalone Impeller library with a single-header API. labels Oct 8, 2024
@chinmaygarde chinmaygarde self-assigned this Oct 8, 2024
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2024
@auto-submit auto-submit bot merged commit 0e7344a into flutter:main Oct 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 8, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 8, 2024
…156435)

flutter/engine@ea4a00f...0e7344a

2024-10-08 [email protected] [Impeller] libImpeller: Fix typo in public API. (flutter/engine#55750)
2024-10-08 [email protected] [Impeller] libImpeller: Allow wrapping external texture handles. (flutter/engine#55664)
2024-10-08 [email protected] Added mutex to the pending gpu tasks deque. (flutter/engine#55748)
2024-10-08 [email protected] Roll Skia from 857248fe0a9a to 8a2fe88d31e3 (7 revisions) (flutter/engine#55749)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@chinmaygarde chinmaygarde deleted the fixintrinsictypo branch October 18, 2024 20:11
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller e: libimpeller The standalone Impeller library with a single-header API.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants