This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] libImpeller: Allow wrapping external texture handles. #55664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
added
the
e: libimpeller
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
This should work but I'm wiring up the test harness to work with "external" textures. Labeling this WIP till I sort out the test. @lyceel, once this lands, all the deliverables we discussed earlier this week should be done! |
Member
Author
|
Added a test. |
chinmaygarde
added
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 8, 2024
…156435) flutter/engine@ea4a00f...0e7344a 2024-10-08 [email protected] [Impeller] libImpeller: Fix typo in public API. (flutter/engine#55750) 2024-10-08 [email protected] [Impeller] libImpeller: Allow wrapping external texture handles. (flutter/engine#55664) 2024-10-08 [email protected] Added mutex to the pending gpu tasks deque. (flutter/engine#55748) 2024-10-08 [email protected] Roll Skia from 857248fe0a9a to 8a2fe88d31e3 (7 revisions) (flutter/engine#55749) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#156013