This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add support for et test //flutter/path/to/dart_test
#55638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbaker
reviewed
Oct 4, 2024
| ); | ||
| }); | ||
|
|
||
| test('parses a dart_test action as an executable', () async { |
Contributor
There was a problem hiding this comment.
I think this test is the best documentation of what keys should exist in a test action. No change requested in this PR but you might consider where these keys should be documented as the complexity grows.
cbracken
reviewed
Oct 4, 2024
matanlurey
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/55638, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 5, 2024
…156258) flutter/engine@bc5f9fc...fd6082a 2024-10-04 [email protected] Roll Dart SDK from ecba03620fc8 to c1c971fd1b94 (2 revisions) (flutter/engine#55668) 2024-10-04 [email protected] Add --rbe-force-local flag to force rbe task execution to happen on the local machine (flutter/engine#55635) 2024-10-04 [email protected] Roll Skia from 4aff9603622d to 9145d1ef9638 (2 revisions) (flutter/engine#55665) 2024-10-04 [email protected] Add support for `et test //flutter/path/to/dart_test` (flutter/engine#55638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…#55638) Closes flutter#147013. Closes flutter#147071. /cc @reidbaker who I know wants to do this for the Java rules soon TM. /cc @jtmcdole, @zanderso for visibility.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#147013.
Closes flutter/flutter#147071.
/cc @reidbaker who I know wants to do this for the Java rules soon TM.
/cc @jtmcdole, @zanderso for visibility.