This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] clamp render target size at max texture size. #55628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Oct 3, 2024
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/55628, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
Hey, found a real bug. That maximum texture size we can allocate is not the same as the maximum render target size. These are separate vulkan capabilities. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 4, 2024
…156206) flutter/engine@66d397d...c2a9fb0 2024-10-04 [email protected] Roll Skia from e732cdf455c8 to cef6e8423365 (1 revision) (flutter/engine#55644) 2024-10-04 [email protected] [Impeller] clamp render target size at max texture size. (flutter/engine#55628) 2024-10-04 [email protected] Roll Skia from 379139f0bebe to e732cdf455c8 (11 revisions) (flutter/engine#55642) 2024-10-04 [email protected] [Impeller] remove aiks color_source. (flutter/engine#55603) 2024-10-04 [email protected] Roll Dart SDK from 91d39199994c to b96383c6bddd (1 revision) (flutter/engine#55641) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…ine#55628) Part of flutter#128912 If an intermediate render target would be larger than the max texture size, then clamp the texture.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#128912
If an intermediate render target would be larger than the max texture size, then clamp the texture.