This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactor FlKeyboardHandler #55601
Merged
Refactor FlKeyboardHandler #55601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-ancell
force-pushed
the
linux-keyboard-handler-tidy-up
branch
from
2cdb72f to
bc3f32e
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 4, 2024
…156188) flutter/engine@20369c5...66d397d 2024-10-04 [email protected] Add missing license headers to `engine_tool`. (flutter/engine#55636) 2024-10-03 [email protected] Refactor FlKeyboardHandler (flutter/engine#55601) 2024-10-03 [email protected] Add and use a `dart_test` rule. (flutter/engine#55630) 2024-10-03 [email protected] Roll Dart SDK from 4c767e0fae21 to 91d39199994c (1 revision) (flutter/engine#55631) 2024-10-03 [email protected] [Impeller] ensure one AiksContext per app. (flutter/engine#55629) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Refactor FlKeyboardHandler to be more GObject and less C++. Done as we will need to move the handler from FlView to FlEngine to support multi-view.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor FlKeyboardHandler to be more GObject and less C++.
Done as we will need to move the handler from FlView to FlEngine to support multi-view.