This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Shift --no-prebuilt-dart-sdk build to linux_unopt #55597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Oct 2, 2024
zanderso
added
autosubmit
zanderso
force-pushed
the
move-no-prebuilt-dart-build
branch
from
1155e77 to
fbf6a91
Compare
Member
Author
|
Added some comments to the json files. Unfortunately, there's a little more cleanup to do before a test could enforce this: There are still some tests running where they shouldn't be, and some builds without |
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 3, 2024
…156124) flutter/engine@70232fa...bd44b58 2024-10-02 [email protected] Shift --no-prebuilt-dart-sdk build to linux_unopt (flutter/engine#55597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
This is my bad for not having this documented better/at-all, but since this build does not produce artifacts, it should not go under a builder that is marked as `release_build: "true"` in the .ci.yaml. This PR moves the build to `linux_unopt.json`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my bad for not having this documented better/at-all, but since this build does not produce artifacts, it should not go under a builder that is marked as
release_build: "true"in the .ci.yaml. This PR moves the build tolinux_unopt.json.