This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
(WIP) Scribe gestures #55568
Closed
Closed
(WIP) Scribe gestures #55568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2024
Member
Monorepo Migration Completed
The
This is a canned message |
Contributor
Author
|
On it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Android Scribe handwriting input gestures, such as circle to select and scratch out to delete.
Must be merged after #52943.
API
My intent is to mirror the native Android API.
Preview will be harder because it will require framework=>engine calls to cancel, etc.
This PR may be further split into separate gestures and separate previewing.
See also
Main Scribe issue:
flutter/flutter#115607
Core Scribe functionality PRs:
flutter/flutter#148784
#52943
Scribe hover icon:
flutter/flutter#155948
#55532