This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "[canvaskit] Further improve overlay optimization by splitting pictures" #55563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion by s…" This reverts commit f3b11bc.
…t_746149965de9d31687096a857f58bec6fd71ec2b
yjbanov
reviewed
Oct 2, 2024
| List<CkManagedSkImageFilterConvertible> imageFilterStack = | ||
| <CkManagedSkImageFilterConvertible>[]; | ||
|
|
||
| late CkPictureRecorder measuringRecorder; |
Contributor
There was a problem hiding this comment.
Does it need to be late if it's initialized immediately in the constructor?
Contributor
Author
There was a problem hiding this comment.
Yes for measuringRecorder but measuringCanvas still needs to be late because I can't use a initializer in the constructor to set it because you can't reference instance fields in the initializers.
| /// A compositor for embedded HTML views. | ||
| final HtmlViewEmbedder viewEmbedder; | ||
|
|
||
| void dispose() { |
Contributor
There was a problem hiding this comment.
Once disposed of, it looks like MeasureVisitor is no longer usable. Should we have a _isDisposed flag that we can assert on inside the methods? Otherwise, we'd be attempting to use a dangling pointer.
Contributor
Author
There was a problem hiding this comment.
That might be a little overkill since MeasureVisitor is only used one place, then immediately disposed and goes out of scope.
harryterkelsen
commented
Oct 2, 2024
| /// A compositor for embedded HTML views. | ||
| final HtmlViewEmbedder viewEmbedder; | ||
|
|
||
| void dispose() { |
Contributor
Author
There was a problem hiding this comment.
That might be a little overkill since MeasureVisitor is only used one place, then immediately disposed and goes out of scope.
| List<CkManagedSkImageFilterConvertible> imageFilterStack = | ||
| <CkManagedSkImageFilterConvertible>[]; | ||
|
|
||
| late CkPictureRecorder measuringRecorder; |
Contributor
Author
There was a problem hiding this comment.
Yes for measuringRecorder but measuringCanvas still needs to be late because I can't use a initializer in the constructor to set it because you can't reference instance fields in the initializers.
yjbanov
approved these changes
Oct 2, 2024
harryterkelsen
added
the
autosubmit
auto-submit
bot
deleted the
revert-55501-revert-55464-revert-55456-revert_746149965de9d31687096a857f58bec6fd71ec2b
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2024
… splitting pictures" (flutter/engine#55563)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 2, 2024
…156118) flutter/engine@751ab9b...33ac1b3 2024-10-02 [email protected] Roll Dart SDK from 7d0becb773d1 to 14b931c40076 (2 revisions) (flutter/engine#55594) 2024-10-02 [email protected] Remove all use of `gn desc` global test fixtures. (flutter/engine#55592) 2024-10-02 [email protected] Roll Skia from 61bb59fcef34 to 40d51ebc76db (1 revision) (flutter/engine#55593) 2024-10-02 [email protected] Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55563) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
brandon-bethke-timu
pushed a commit
to timu-com/engine
that referenced
this pull request
Oct 4, 2024
… pictures" (flutter#55563) This enhances the overlay optimization by delaying combining pictures to get tighter bounds for the pictures that make up the scene, enabling more sophisticated optimization since we can determine if they intersect with platform views on a per-picture basis. Fixes flutter/flutter#149863 Fixes flutter/flutter#155833 On a Macbook in Chrome in an example app with an infinite scrolling grid of platform views, this brings the ratio of dropped frames from 93% to 55% (roughly 4 fps to 30 fps). This is a reland of flutter#54878 with a fix for scenes with pictures and shader masks that are eventually entirely clipped out. It also fixes a performance issue caused by making too many Canvases just to record the size of the picture elements in the scene. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Member
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 18, 2024
… pictures" (flutter/engine#55563) This enhances the overlay optimization by delaying combining pictures to get tighter bounds for the pictures that make up the scene, enabling more sophisticated optimization since we can determine if they intersect with platform views on a per-picture basis. Fixes #149863 Fixes #155833 On a Macbook in Chrome in an example app with an infinite scrolling grid of platform views, this brings the ratio of dropped frames from 93% to 55% (roughly 4 fps to 30 fps). This is a reland of flutter/engine#54878 with a fix for scenes with pictures and shader masks that are eventually entirely clipped out. It also fixes a performance issue caused by making too many Canvases just to record the size of the picture elements in the scene. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhances the overlay optimization by delaying combining pictures to get tighter bounds for the pictures that make up the scene, enabling more sophisticated optimization since we can determine if they intersect with platform views on a per-picture basis.
Fixes flutter/flutter#149863
Fixes flutter/flutter#155833
On a Macbook in Chrome in an example app with an infinite scrolling grid of platform views, this brings the ratio of dropped frames from 93% to 55% (roughly 4 fps to 30 fps).
This is a reland of #54878 with a fix for scenes with pictures and shader masks that are eventually entirely clipped out. It also fixes a performance issue caused by making too many Canvases just to record the size of the picture elements in the scene.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.