This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Migrate off a global test fixture for build and lint.
#55540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmccutchan
approved these changes
Oct 1, 2024
Contributor
johnmccutchan
left a comment
johnmccutchan
left a comment
There was a problem hiding this comment.
Nice cleanup! Thanks!
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 1, 2024
…156010) flutter/engine@d02a10f...e127e78 2024-10-01 [email protected] Roll Skia from 44d45ac4de6f to 5fb36dd08a25 (5 revisions) (flutter/engine#55561) 2024-10-01 [email protected] Migrate off a global test fixture for `build` and `lint`. (flutter/engine#55540) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Oct 1, 2024
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 18, 2024
…gine#55540) Partial work towards #148420, unblocks flutter/engine#55537. These tests can now be more precise, and changing the fixtures no longer has side-effects on tests across the entire repository. There are about 11 other usages (there were ~50 in these) after this PR that I'll get to, as well as the hard-coded `gn desc` output, before retiring `fixtures.dart`
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 18, 2024
The logical "part 2" of the work started in flutter/engine#55540. Test output does not change, the tests just no longer rely on the global `fixtures.dart` data.
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 18, 2024
The logical "part 2.5" of the work started in flutter/engine#55540. Test output does not change, the tests just no longer rely on the global `fixtures.dart` data.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial work towards flutter/flutter#148420, unblocks #55537.
These tests can now be more precise, and changing the fixtures no longer has side-effects on tests across the entire repository. There are about 11 other usages (there were ~50 in these) after this PR that I'll get to, as well as the hard-coded
gn descoutput, before retiringfixtures.dart