Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jason-simmons
Copy link
Member

Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @flar

Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 3, 2024
@auto-submit auto-submit bot merged commit 302561c into flutter:main Oct 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 3, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 3, 2024
…156160)

flutter/engine@247bc68...de1762d

2024-10-03 [email protected] Roll Skia from fe3cd2adeaaa to 379139f0bebe (2 revisions) (flutter/engine#55617)
2024-10-03 [email protected] [Impeller] Fix handling of perspective matrices in Matrix::Translate (flutter/engine#55536)
2024-10-03 [email protected] Roll Skia from 68fea8aa589b to fe3cd2adeaaa (1 revision) (flutter/engine#55613)
2024-10-03 [email protected] Roll Dart SDK from 1c2e6ad84af1 to 4c767e0fae21 (1 revision) (flutter/engine#55612)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.24.x introduced a regression in Golden Tests using a widget with a matrix perspective transform

3 participants