Added metal validation for `impeller_unittests #55527
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
Can you add context for this change in the PR description?
For example, why (to your knowledge) was this not enabled previously, why are we enabling it now (was there a discussion on another thread/issue, or was it a shower thought), etc?
Done, ptal |
|
(This should also match the conditions with which we are running tests on CI) |
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
Approved, assuming that we don't hit failures on CI ;)
|
test-exempt: Test configuration only. |
gaaclarke
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/55527, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Iirc we have these settings provided in run_test.py |
gaaclarke
added
the
autosubmit
…155967) flutter/engine@e61bc85...bfb6ddd 2024-09-30 [email protected] Roll Skia from 534633fb4bd9 to d1d7deb68f9d (1 revision) (flutter/engine#55534) 2024-09-30 [email protected] Roll Dart SDK from 79863e31de87 to d9fb41a4b5ee (1 revision) (flutter/engine#55533) 2024-09-30 [email protected] Introduce a GN rule that (explicitly) generates a `dart test` wrapper (flutter/engine#55475) 2024-09-30 [email protected] Remove the need to use `runZoned` by replacing `print` statements (flutter/engine#55530) 2024-09-30 [email protected] Roll Skia from 6c89706638ee to 534633fb4bd9 (2 revisions) (flutter/engine#55531) 2024-09-30 [email protected] [Impeller] Create a libImpeller dylib and expose symbols. (flutter/engine#55526) 2024-09-30 [email protected] Added metal validation for `impeller_unittests (flutter/engine#55527) 2024-09-30 [email protected] Roll Skia from dfeeb199b226 to 6c89706638ee (2 revisions) (flutter/engine#55528) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#155967) flutter/engine@e61bc85...bfb6ddd 2024-09-30 [email protected] Roll Skia from 534633fb4bd9 to d1d7deb68f9d (1 revision) (flutter/engine#55534) 2024-09-30 [email protected] Roll Dart SDK from 79863e31de87 to d9fb41a4b5ee (1 revision) (flutter/engine#55533) 2024-09-30 [email protected] Introduce a GN rule that (explicitly) generates a `dart test` wrapper (flutter/engine#55475) 2024-09-30 [email protected] Remove the need to use `runZoned` by replacing `print` statements (flutter/engine#55530) 2024-09-30 [email protected] Roll Skia from 6c89706638ee to 534633fb4bd9 (2 revisions) (flutter/engine#55531) 2024-09-30 [email protected] [Impeller] Create a libImpeller dylib and expose symbols. (flutter/engine#55526) 2024-09-30 [email protected] Added metal validation for `impeller_unittests (flutter/engine#55527) 2024-09-30 [email protected] Roll Skia from dfeeb199b226 to 6c89706638ee (2 revisions) (flutter/engine#55528) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
This turns on Metal validation for launching impeller_unittests from the tests panel. This matches the default behavior of launching tests from XCode. Without these assertions errors in Metal are completely silent. In my case I just got a black screen until I tried running the tests through xcode.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.