This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Reland "[canvaskit] Further improve overlay optimization by splitting pictures"" #55501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plitting…" This reverts commit e57b440.
harryterkelsen
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/55501, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
harryterkelsen
added
the
autosubmit
auto-submit
bot
deleted the
revert-55464-revert-55456-revert_746149965de9d31687096a857f58bec6fd71ec2b
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 28, 2024
…ation by splitting pictures"" (flutter/engine#55501)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 28, 2024
…155865) flutter/engine@9c8e5cb...f3b11bc 2024-09-28 [email protected] Revert "Reland "[canvaskit] Further improve overlay optimization by splitting pictures"" (flutter/engine#55501) 2024-09-28 [email protected] Migrate `try/finally` calls to `addTearDown`. (flutter/engine#55499) 2024-09-27 [email protected] iOS: Migrate FlutterAppDelegate to ARC (flutter/engine#55472) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Oct 1, 2024
…lutter#155865) flutter/engine@9c8e5cb...f3b11bc 2024-09-28 [email protected] Revert "Reland "[canvaskit] Further improve overlay optimization by splitting pictures"" (flutter/engine#55501) 2024-09-28 [email protected] Migrate `try/finally` calls to `addTearDown`. (flutter/engine#55499) 2024-09-27 [email protected] iOS: Migrate FlutterAppDelegate to ARC (flutter/engine#55472) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #55464
The PR caused a large regression in a web benchmark.