Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

Make it explicit that it's an unopt engine for consistency with the other unopt build descriptions.

Fixup to: #55493

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I promise on my honour to spell "optimised" with a "z"... just this once.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 27, 2024

auto label is removed for flutter/engine/55498, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 27, 2024

auto label is removed for flutter/engine/55498, due to Pull request flutter/engine/55498 is not in a mergeable state.

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 27, 2024

auto label is removed for flutter/engine/55498, due to Pull request flutter/engine/55498 is not in a mergeable state.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2024
Make it explicit that it's an unopt engine for consistency with the
other unopt build descriptions.

Fixup to: #55493
@cbracken cbracken merged commit ff45417 into flutter:main Sep 28, 2024
@cbracken cbracken deleted the doc-doc-dockety-doc-doc branch September 28, 2024 18:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants