This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make arm64 iOS simulator local engine build unopt #55493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most iOS embedder developers rely on two simulator builds: * ios_debug_sim_unopt (for simulators on x64 hosts) * ios_debug_sim_unopt_arm64 (for simulators on arm64 hosts) We specify these two builds, for example, in our iOS unit test Xcode project `testing/ios/IosUnitTests/Tests/FlutterEngineConfig.xcconfig`. Currently `local_engine.json` specifies two simulator builds: * ios_debug_sim_unopt (for simulators on x64 hosts) * ios_debug_sim_arm64 (for simulators on arm64 hosts) While the x64 build specifies the `--unoptimized` flag, the arm64 build does not, which is problematic for those wanting to use both `et` and run the iOS unit tests. This adds the `--unoptimized` flag for consistency with prevailing practice among iOS embedder developers.
matanlurey
approved these changes
Sep 27, 2024
cbracken
added
the
autosubmit
jmagman
reviewed
Sep 27, 2024
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 27, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 27, 2024
…155855) flutter/engine@f21f2b2...f9e4ed2 2024-09-27 [email protected] updated Color docstring to address equality (flutter/engine#55496) 2024-09-27 [email protected] Make arm64 iOS simulator local engine build unopt (flutter/engine#55493) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
cbracken
added a commit
that referenced
this pull request
Sep 28, 2024
Make it explicit that it's an unopt engine for consistency with the other unopt build descriptions. Fixup to: #55493
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Oct 1, 2024
…lutter#155855) flutter/engine@f21f2b2...f9e4ed2 2024-09-27 [email protected] updated Color docstring to address equality (flutter/engine#55496) 2024-09-27 [email protected] Make arm64 iOS simulator local engine build unopt (flutter/engine#55493) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most iOS embedder developers rely on two simulator builds:
We specify these two builds, for example, in our iOS unit test Xcode project
testing/ios/IosUnitTests/Tests/FlutterEngineConfig.xcconfig.Currently
local_engine.jsonspecifies two simulator builds:While the x64 build specifies the
--unoptimizedflag, the arm64 build does not, which is problematic for those wanting to use bothetand run the iOS unit tests.This adds the
--unoptimizedflag for consistency with prevailing practice among iOS embedder developers.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.